From d5b178537f5e3846e22b6aa296c40754b0cb4bf3 Mon Sep 17 00:00:00 2001 From: Armando Montanez Date: Fri, 11 Oct 2024 13:48:01 -0700 Subject: [PATCH] Disable failing checks * Disables Windows, as there's a mix of real build errors and overly-ambitious checks that don't work on Windows. * Disables extra checks temporarily since it's currently failing. --- .github/workflows/bazel_build.yml | 65 ++++++++++++++++--------------- 1 file changed, 33 insertions(+), 32 deletions(-) diff --git a/.github/workflows/bazel_build.yml b/.github/workflows/bazel_build.yml index 7dffdbc9d..bd8fd2308 100644 --- a/.github/workflows/bazel_build.yml +++ b/.github/workflows/bazel_build.yml @@ -7,7 +7,8 @@ jobs: bazel-build-check: strategy: matrix: - os: [ubuntu-latest, windows-latest, macos-latest] + # TODO: Windows is currently broken. + os: [ubuntu-latest, macos-latest] fail-fast: false runs-on: ${{ matrix.os }} steps: @@ -41,34 +42,34 @@ jobs: # Checks that the current BCR-requested version of Picotool builds. - name: Bazel Picotool backwards compatibility run: bazel build @picotool//:picotool - - other-bazel-checks: - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 - - name: Get Bazel - uses: bazel-contrib/setup-bazel@0.9.0 - with: - # Avoid downloading Bazel every time. - bazelisk-cache: true - # Store build cache per workflow. - disk-cache: ${{ github.workflow }} - # Share repository cache between workflows. - repository-cache: true - # Only needed to drive the presbumit scripts. - - name: Setup Python - uses: actions/setup-python@v5 - with: - python-version: '3.10' - - name: Fetch latest Picotool - uses: actions/checkout@v4 - with: - repository: raspberrypi/picotool - ref: develop - fetch-depth: 0 - path: lib/picotool - - name: Other Bazel checks - run: python3 tools/run_all_bazel_checks.py --program=other --picotool-dir=lib/picotool + # Add back when it begins to pass. + # other-bazel-checks: + # runs-on: ubuntu-latest + # steps: + # - name: Checkout + # uses: actions/checkout@v4 + # with: + # fetch-depth: 0 + # - name: Get Bazel + # uses: bazel-contrib/setup-bazel@0.9.0 + # with: + # # Avoid downloading Bazel every time. + # bazelisk-cache: true + # # Store build cache per workflow. + # disk-cache: ${{ github.workflow }} + # # Share repository cache between workflows. + # repository-cache: true + # # Only needed to drive the presbumit scripts. + # - name: Setup Python + # uses: actions/setup-python@v5 + # with: + # python-version: '3.10' + # - name: Fetch latest Picotool + # uses: actions/checkout@v4 + # with: + # repository: raspberrypi/picotool + # ref: develop + # fetch-depth: 0 + # path: lib/picotool + # - name: Other Bazel checks + # run: python3 tools/run_all_bazel_checks.py --program=other --picotool-dir=lib/picotool