Skip to content

Commit

Permalink
Fix some linting issues
Browse files Browse the repository at this point in the history
  • Loading branch information
sevein committed May 2, 2024
1 parent 8858241 commit 6de92c0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
8 changes: 4 additions & 4 deletions hack/ccp/internal/controller/jobs.go
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ func (l *outputDecisionJob) exec(ctx context.Context) (uuid.UUID, error) {

panic("not implemented")

return uuid.Nil, nil
return uuid.Nil, nil // nolint: govet
}

// nextChainDecisionJob.
Expand Down Expand Up @@ -488,7 +488,7 @@ func (l *updateContextDecisionJob) await(ctx context.Context, opts []option) (_
return uuid.Nil, err
}

decision, err := l.j.pkg.AwaitDecision(ctx, opts)
decision, err := l.j.pkg.AwaitDecision(ctx, opts) // nolint: staticcheck
if err != nil {
return uuid.Nil, err
}
Expand All @@ -498,7 +498,7 @@ func (l *updateContextDecisionJob) await(ctx context.Context, opts []option) (_

panic("not implemented")

return decision.uuid(), nil
return decision.uuid(), nil // nolint: govet
}

// directoryClientScriptJob.
Expand Down Expand Up @@ -736,7 +736,7 @@ func (l *outputClientScriptJob) exec(ctx context.Context) (uuid.UUID, error) {

panic("not implemented")

return uuid.Nil, nil
return uuid.Nil, nil // nolint: govet
}

// setUnitVarLinkJob is a local job that sets the unit variable configured in
Expand Down
4 changes: 1 addition & 3 deletions hack/ccp/internal/controller/task.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func newTaskBackend(logger logr.Logger, job *job, config *workflow.LinkStandardT
}
}

func (b *taskBackend) submit(pCtx *packageContext, args string, wantsOutput bool, stdoutFilePath, stderrFilePath string) uuid.UUID {
func (b *taskBackend) submit(pCtx *packageContext, args string, wantsOutput bool, stdoutFilePath, stderrFilePath string) {
t := &task{
ID: uuid.New(),
CreatedAt: time.Now().UTC(),
Expand All @@ -47,8 +47,6 @@ func (b *taskBackend) submit(pCtx *packageContext, args string, wantsOutput bool
}

b.tasks.Tasks[t.ID] = t

return t.ID
}

func (b *taskBackend) wait(ctx context.Context) (*taskResults, error) {
Expand Down

0 comments on commit 6de92c0

Please sign in to comment.