Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: FilesClientScriptJob is not implemented yet #11

Closed
sevein opened this issue Apr 21, 2024 · 2 comments
Closed

Problem: FilesClientScriptJob is not implemented yet #11

sevein opened this issue Apr 21, 2024 · 2 comments
Assignees
@sevein

Comments

@sevein
Copy link
Member

sevein commented Apr 21, 2024

FilesClientScriptJob is the trickiest job type to implement by far for a couple of reasons:

  1. The files iterator walks file records both in the database and the filesystem. I've started implementing this as a rangefunc in Package.Files but it's not reading from the database yet.
  2. It breaks jobs into batches of tasks to speed up processing by MCPClient workers.
@sevein sevein added the Size: L label Apr 21, 2024
@sevein sevein self-assigned this Apr 21, 2024
@sevein
Copy link
Member Author

sevein commented May 2, 2024

FilesClientScriptJob is now working but without batching.

@sevein sevein mentioned this issue May 3, 2024
Closed
@sevein
Copy link
Member Author

sevein commented May 3, 2024

Closing this now since basic support is completed. Batching will be implemented as part of issue #38.

@sevein sevein closed this as completed May 3, 2024
@sevein sevein added this to the Technology Preview milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sevein sevein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sevein