Log from activity interceptor #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to artefactual-sdps/enduro#1015 (comment). This approach makes sure that we always log the worker activity execution event regardless whether the activity implementor did any logging, and this is true even for internal activities like
internalSessionCreationActivitythat the application developer doesn't own.This:
Becomes:
The main difference is that we can't include the file name or line number (from the goroutine stack) because that information is only available to the callee - not sure if that's enough to reject this idea. This is also the case in the traces that we're emitting with the trace interceptor.