Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new variable to process transfer source folder deletion #139

Closed
wants to merge 1 commit into from

Conversation

mutanthumb
Copy link

@mutanthumb mutanthumb commented Nov 1, 2023

added new variable "--transfer_delete_path" to delete folder from watched folder after transfer is complete.

This is to resolve: #127

added new variable "--transfer_delete_path" to delete folder from watched folder after transfer is complete.
@mutanthumb
Copy link
Author

I haven't done a pull request in years so if I screwed this up please let me know!

@mamedin
Copy link
Contributor

mamedin commented Nov 23, 2023

That's was fine @mutanthumb . Your PR was perfect, but yesterday a new commit was added to our main branch and had a conflict with your commit.

I have rebased your branch with latest commits and fixed the conflict, and create a new branch in our repo:

I'm going to close this PR and create a new one using the new branch, but using your commit (I only changed a LOGGER line).

@mutanthumb you did all fine, we need to change it because our latest changes and to make the code review and merge easier.

@mamedin
Copy link
Contributor

mamedin commented Nov 23, 2023

Closed in favor of #141

@mamedin mamedin closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete on complete doesn't work in transfer.py
2 participants