Improve argument restrictions #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove agent vars from being selected when agent is observer
|
Doing this in a PR as it's slightly more radical. |
|
This PR now includes code so that things respect |
|
That is, includes fix for #6 |
arthurhjorth
added a commit
that referenced
this pull request
May 6, 2015
Improve argument restrictions
| ] | ||
| table:to-list tasks | ||
| ] | ||
| if the-type = "value"[ | ||
| report filter [ | ||
| table:get last ? "type" = "value" | ||
| table:get last ? "type" = "value" and | ||
| table:get last ? "visible" |
There was a problem hiding this comment.
There's a lot of shared logic in these cases that could probably be pulled out into a reporter. Something like:
to-report visible-interaction-filter [t type context other-filter]
task [
table:get last ? "type" = type and
table:get last ? "visible" and
run-result other-filter (table-get last ?)
]
end
|
Looks fine to me. I left a few comments, but they are sort of nitpicky and I think that if this works, it's good to go. |
|
Awesome, thanks @mrerrormessage. I'll refactor a bit, but wait till after today :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refines which arguments show up when. There are still invalid choices, but fewer. Also, fixes #52.