Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2024.04 #50

Merged
merged 1,249 commits into from
Apr 26, 2024
Merged

v2024.04 #50

merged 1,249 commits into from
Apr 26, 2024

Conversation

lukeshingles
Copy link
Member

@lukeshingles lukeshingles commented Jan 24, 2024

  • Add VPKT_WRITE_CONTRIBS option to save all virtual packets contributions for later time and wavelength binning, with emission/absorption types by artistools.

  • Improve performance by enabling fast-math compiler options, constexpr radfield bins, improving bound-free estimator accumulation, removing storage for empty cells, and using node shared memory for initmassfracstable, elem_meanweight.

    • 3D AD2 (Shingles et al. 2023) 1e8pkt 1920 core JUWELS runtime decreased from 210k core hrs to 134k core hrs (1.56x faster). Memory per core decreased from 2.8GB to 1.5GB.
    • W7 (Shingles et al. 2022) nebular 960 core 2e9pkt 150-410d JUWELS runtime decreased from 13.6k core hrs (20230811 version) to 10.4k core hrs (1.31x faster). Compared to the 2022 published version with 18.6k core hrs, this is 1.79x faster.
      • With a Simpson rule integrator in place of GSL's adaptive method (producing identical observables) runtime decreases to 6.83k core hours, 1.99x faster than 20230811 and 2.72x faster than the 2022 published version.
    • subMch Shen+2018 nebular 960 core 1e9pkt 150-410d runtime decreased from 13.14k core hrs (20210417 version) to 7.30 kCore hours (1.80x faster). With Simpson rule integrator, runtime decreased to 6.07 k core hrs (2.16x faster)
    • sim2010 classic mode 2-120 days 2e7pkt 960 core JUWELS runtime decreased from 3.81k core hrs (20230526 version) to 1.87k core hrs (2.04x faster). Compared to ARTIS classic with 11.45k core hrs, this version is 6.13x faster.
  • Reduce memory per core to enable future GPU support. All threads now share a single cell cache and operate on packets within the same cell. This may later be expanded to multiple cell caches to increase thread occupancy as memory allows.

  • Enable C++ standard parallelism for packet propagation (for future GPU offloading).

  • Fix virtual packets for models with internal empty cells. Passing into an empty cell previously triggered instant escape.

  • Fix a 1e5 factor in free-free opacity for opacity case 5 (Tanaka Ye-dependent grey mode and line-by-line non-grey mode for kilonovae). This increased the 3D AD2 (Shingles et al. 2023) early luminosity by about 20%. The spectra are almost unchanged (except for being brighter)

  • Reduce noise in particle deposition rate estimators by contributing partial deposition of packet energy prior to Monte Carlo transition event (similar to gamma deposition rates from path estimators).

  • Add support for calculating and using expansion opacities.

  • Add option for XCOM gamma-ray photoionization #52 by Gerrit Leck

  • Add option to limit number of BF estimators #47 by Josh Pollin

  • Add some fixes to hybrid LTE-NLTE mode by Christine Collins

@lukeshingles lukeshingles changed the title v2024.02 v2024.03 Feb 22, 2024
This reverts commit a531bbc.
commit d767554
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Tue Apr 23 08:50:00 2024 +0100

    Update .clang-tidy

commit 507fd1f
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Mon Apr 22 09:36:40 2024 +0100

    Revert "Update ci-checks.yml"

    This reverts commit 6e4508a.

commit 6e4508a
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Mon Apr 22 08:58:46 2024 +0100

    Update ci-checks.yml

commit 538b976
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Mon Apr 22 08:56:52 2024 +0100

    Update ci-checks.yml

commit f6634c6
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Mon Apr 22 08:54:08 2024 +0100

    Update ci-checks.yml

commit 946c51a
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Mon Apr 22 08:48:32 2024 +0100

    Update ci-checks.yml

commit ecea2ef
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Mon Apr 22 08:46:57 2024 +0100

    Update ci-checks.yml

commit 9f292b1
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Sun Apr 21 22:55:58 2024 +0100

    Update ci-checks.yml

commit 667602a
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Sun Apr 21 22:46:50 2024 +0100

    Update gammapkt.cc

commit ef779e2
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Sun Apr 21 22:43:03 2024 +0100

    const args to vec_scale

commit 0b5b13a
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Sun Apr 21 22:09:21 2024 +0100

    Revert "Update vectors.h"

    This reverts commit 64a1b5f.

commit 5cbc028
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Sun Apr 21 22:08:38 2024 +0100

    Revert "Update vectors.h"

    This reverts commit 9725578.

commit 64a1b5f
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Sun Apr 21 21:57:23 2024 +0100

    Update vectors.h

commit 9725578
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Sun Apr 21 21:57:13 2024 +0100

    Update vectors.h

commit d07436e
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Sun Apr 21 21:55:26 2024 +0100

    Update vectors.h

commit 7c7617b
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Sun Apr 21 21:55:05 2024 +0100

    Update vectors.h

commit 4ba67e1
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Sun Apr 21 21:53:21 2024 +0100

    Update vectors.h

commit 366beca
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Sun Apr 21 21:52:57 2024 +0100

    Update spectrum_lightcurve.cc

commit 37a89b3
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Fri Apr 19 16:49:31 2024 +0100

    Update vpkt.cc

commit 98342bb
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Fri Apr 19 05:45:17 2024 +0100

    Enable APPTAINER_SHARENS

commit a721ba9
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Wed Apr 17 15:18:18 2024 +0100

    Update exspec-after.sh

commit 2f5d0b2
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Wed Apr 17 14:44:03 2024 +0100

    Update checksums for absorption_freq condition on vpackets

commit 309981d
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Wed Apr 17 14:07:30 2024 +0100

    Write vpkt contribs when absorption_freq is in range (even if nu_rf is not)

commit e0fe044
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Wed Apr 17 14:05:38 2024 +0100

    Update rpkt.cc

commit 3d39400
Author: Luke Shingles <luke.shingles@gmail.com>
Date:   Wed Apr 17 14:04:45 2024 +0100

    Rename obsbin to obsdirindex for virtual packets
@lukeshingles lukeshingles changed the title v2024.04 v2024.04.26 Apr 26, 2024
@lukeshingles lukeshingles marked this pull request as ready for review April 26, 2024 08:58
@lukeshingles lukeshingles enabled auto-merge (squash) April 26, 2024 09:01
@lukeshingles lukeshingles changed the title v2024.04.26 v2024.04 Apr 26, 2024
@lukeshingles lukeshingles merged commit d9e7d90 into main Apr 26, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants