-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XCOM gamma-ray photoionization #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
…nto xcom_photoion
commit cb5d80656b7c8fe270dba76ee0dc45107e1c2b18 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 22 09:09:22 2024 +0000 Update Makefile commit 8417a3b3e4686c2f3ae0469932049166df5e41ce Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 22 08:53:21 2024 +0000 Update radfield.cc commit ef49dcef8b7420d78999b34c437581ce14533f24 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 22 08:38:54 2024 +0000 Update sn3d.h commit 941ea3000037e05d10456cd8d6ee515583a604f6 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 22 08:35:20 2024 +0000 Update ratecoeff.h commit 49b653f88423fed1178255822a419d608308fa57 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 16:54:15 2024 +0000 Update radfield.cc commit bcba6cd70662e6f43c68932ac9e6478f8296b9ee Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 16:53:54 2024 +0000 Update thermalbalance.cc commit 820822c5b5293b3aa879cffbae9d28eeb932b301 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 16:46:41 2024 +0000 Update ratecoeff.cc commit 7bb93f984edad707af93812b8ce1f473b37a55cf Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 16:46:25 2024 +0000 Update radfield.cc commit c90c28ee2f233b7a03d6628f5f718efeeeb1035d Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 13:19:09 2024 +0000 Update sn3d.cc commit e7a329dc9184184c3fbb0991d2631448f37fd59e Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 11:27:18 2024 +0000 Update Makefile commit 3361b3ee06a54448e7af1d368819fd71ed6aa6f4 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 11:17:35 2024 +0000 Add USE_SIMPSON_INTEGRATOR constant commit b88dedf356041a368971f9f51a947eab6272c805 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 09:39:14 2024 +0000 thermalbalance.cc: use integrator template commit fd95245a7ea18f0aa944efa392b32b700da8f85e Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 09:33:31 2024 +0000 Update thermalbalance.cc commit 1ef29143b2ef665d9ebb287508699a0e692e803c Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 09:29:30 2024 +0000 radfield.cc: use integrator template commit 7a8f929a3ab492a84ecd9004827e4f92a28688d0 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 09:26:27 2024 +0000 Update radfield.cc commit 4710227a599b06f50e18411fa724fe85fb197809 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 09:12:39 2024 +0000 macroatom: use EULERGAMMA constant commit eacbb6c7ef0c409710f359596790f8e7eed3bedf Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 09:06:07 2024 +0000 Update sn3d.cc commit 0113251d9860446e8d42c17c5f6e0038aceb9ef9 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 08:59:04 2024 +0000 Set EULERGAMMA constant commit 43a27a4d74560367ec1acaa5c52379bc44d754b4 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 08:56:43 2024 +0000 Update sn3d.cc commit ddbf5151a57f39c7255d9f4b720ca4984e49a60b Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 08:48:09 2024 +0000 Update nonthermal.cc commit c5e9e70166df0dfe4511233dfc317435fad02d7b Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 08:45:50 2024 +0000 Update nonthermal.cc commit 41663dde4a854fe505c1b7e7171552cfa5accf08 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 08:33:18 2024 +0000 Update kpkt.cc commit 044677073c0562c3dc69679e967dd75cb86280eb Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 08:28:49 2024 +0000 Update sn3d.cc commit 007d1e47e36190019bc8531cb48b9031a9a2d97f Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 08:25:06 2024 +0000 Remove TRACK_ION_MASTATS (on if TRACK_ION_STATS) commit e85f77f68ee958bb5ed70ce2120b782864f54568 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 08:14:09 2024 +0000 Update sn3d.h commit 7819585ee70715bf3a770af8a07e0769d5ae67cd Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 08:13:59 2024 +0000 Update ratecoeff.h commit fb035e3007cb43b6497d185d2b354483d217290b Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 21 08:02:28 2024 +0000 Use thread_local gslworkspace commit a2cd187f5ce74d93dad38da5b31e6ac32387ae8c Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 17:45:42 2024 +0000 Update ratecoeff.cc commit dedd196b6ba1094e969b5a82eebb951b9dba0b1e Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 17:39:19 2024 +0000 refactor integrator template commit c320c48bce37f1fbf4909c57290a7bcba06a8273 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 16:52:39 2024 +0000 Refactor omp sections commit 545a440111ecb77a56c61553b3a0c2a0d142ed5d Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 16:41:55 2024 +0000 Rename safeadd to atomicadd commit 9f2695b6e0f133f1ddaf5b03dc5c1ebe632b99e5 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 16:29:39 2024 +0000 Update decay.cc commit ed784786ee758261084919d47753c96f841abf04 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 16:28:52 2024 +0000 Update packet.cc commit e88f756c2b87360ba0dbc5270e27f8365ee857fb Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 16:26:29 2024 +0000 Fix includes commit 3653253550860626343662697518cc31b477e273 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 16:25:35 2024 +0000 use vector for timesteps commit 3d7065f8256d7d4ea8149df385e7471bc33a6555 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 16:10:45 2024 +0000 Remove unused counters commit 1120108db37eb4fb2d1dc0b3168a29cae0787956 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 16:08:04 2024 +0000 Use atomic operations only for multithread mode commit cb480170310819b93753ec6bab1a0a45cc313ed0 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 11:06:41 2024 +0000 Update sn3d.cc commit 9d2fd7e0bbcfa3c686ac6c7c87763ed8cadcf1fd Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 11:01:38 2024 +0000 Update sn3d.h commit 12165d0d4ddd1f0372f96e0f1ff27a25455329d6 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 10:50:51 2024 +0000 Update Makefile commit 3ab68c155c37c3f9dc64c4b57842e89f4bd1da5e Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 10:45:09 2024 +0000 Update ci-checks.yml commit 1c3ebc4f2ca2622024347e925481d4fcf755d257 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 10:34:57 2024 +0000 Update Makefile commit cb5d17e3e8feb4dba9a1f6b058d9ba41310c23b1 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 10:25:21 2024 +0000 Update Makefile commit 4838fb98b1021c8115bb3587aaab0ff40f984663 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 10:14:31 2024 +0000 Update sn3d.cc commit a7c5013722140dd2cd495757c53a505fe669b9db Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 20 09:31:06 2024 +0000 Update Makefile commit c23c5068aca7ef9070a45ae201dccdf022761695 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 19 17:51:54 2024 +0000 move struct ModelCellElement into namespace grid commit c60913b5328fb21a35842e93518e4c2aeb9ea20f Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 19 17:45:40 2024 +0000 Update grid.cc commit 7c77f7cd3864e97387a23b96b6cc6c2f51944331 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 19 17:40:44 2024 +0000 Move change_cell to grid.h commit 9e3f49f1e225a15e0d35ef7338a83664831501eb Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 19 16:02:38 2024 +0000 Update Makefile commit d89c84d8e423a29c691402b3e7a25035311578ad Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 19 15:35:32 2024 +0000 Update Makefile commit 75a6e7ff6a4035dbba474903ca114129cbf99cbf Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 19 11:31:48 2024 +0000 Update Makefile commit e6a929e83d20f24efc61ce090aeddafb816d7b83 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 19 11:23:19 2024 +0000 Update Makefile commit 25fd1a9defeb28b4b501c8ff2750e2b34e6e086b Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 19 03:09:42 2024 +0000 Update input.cc commit 1d8db70f5fbd593e5d3532b5b440fc289694ee41 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 19 03:09:25 2024 +0000 Update ratecoeff.cc commit 6e8964c0ded3796e8a80223c2a28d851377cf03c Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 18 22:59:13 2024 +0000 Update sn3d.h commit 1af6889a62fcc0a5fb215eb1a8606f95ce7c1c75 Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 18 17:32:59 2024 +0000 Update sn3d.h commit 169118b07c451e783b8ff289063d7e7eefc70914 Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 18 17:27:38 2024 +0000 Revert checksum change for non-thread_local rng commit 4e6873bb6afa3a359a76892cd5a40db0adba9880 Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 18 17:02:44 2024 +0000 Update sn3d.cc commit 7d3e7c0dd39674c1c8d578dc66412883f51924e8 Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 18 16:53:41 2024 +0000 Revert thread_local stdrng commit c9a17b8e967d3d762d891e0ecaa9f983595be09d Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 18 16:51:21 2024 +0000 Update sn3d.h commit 7a02a8d346206be4c050067e946d9cd5bf0a4ffd Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 18 16:38:26 2024 +0000 Update update_packets.cc commit f1c21d1a4ab5db3ac1f72353d6c6b3b1dc9a287d Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 18 16:38:14 2024 +0000 Update sn3d.h commit 769c0662ddb114d66c28c53d99db27d66acf156e Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 18 16:37:52 2024 +0000 Update Makefile commit 5e8d00e64ab3da395f7964d90dc287c432242d0c Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 18 16:32:38 2024 +0000 Update input.cc commit 81174cc375e67a9f6814de81b09fe767d3d3f428 Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 18 13:10:01 2024 +0000 Revert "Update Makefile" This reverts commit 18a6820b9d2cd1086ba003b7ed69de6f89d7ec1f. commit a6123c690fb20ad88f8397291a6b34cf30cb7795 Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 18 13:09:56 2024 +0000 Revert "Update ci-checks.yml" This reverts commit 60a1d2f0f4001b40034aff825ff7646074758973. commit 60a1d2f0f4001b40034aff825ff7646074758973 Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 18 13:00:51 2024 +0000 Update ci-checks.yml commit 18a6820b9d2cd1086ba003b7ed69de6f89d7ec1f Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 18 12:33:13 2024 +0000 Update Makefile commit f9f129347a637fd18d311affbf34426251464715 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 17 21:45:53 2024 +0000 Revert "Update update_packets.cc" This reverts commit 799d8ecbd0bd18ec80c271eacf2dea28d4208119. commit 799d8ecbd0bd18ec80c271eacf2dea28d4208119 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 17 21:38:36 2024 +0000 Update update_packets.cc commit e55ebc061a37701dec481877754eac59cbdf9472 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 17 21:30:26 2024 +0000 Update update_packets.cc commit d1b1f7b0d98ec98370a69afde03bf50a863c5832 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 17 21:18:40 2024 +0000 Update ci-checks.yml commit 9dbb9e86111869bf5cc067ae16705b05081baba8 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 17 21:18:24 2024 +0000 Update Makefile commit 7c08911f0f964c1a4542f14fe12db06e9a5efec3 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 17 21:12:39 2024 +0000 Make use_cellcache and gslworkspace inline in sn3d.h commit 3fc4b460cfbdc711bb8cf63d5eeb6991314026ab Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 17 21:07:50 2024 +0000 Update sn3d.h commit b0c5c0448bd20297580e4a40000b7c3d00a15508 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 17 21:03:50 2024 +0000 Revert "Use inline in sn3d.h for exspec/sn3d shared variables" This reverts commit e02db34b512a4b907b80216ab88bcf2da52cfa12. commit 1ed74608784c37c9a0880ad590ff76689081c836 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 17 20:54:49 2024 +0000 Update sn3d.h commit e02db34b512a4b907b80216ab88bcf2da52cfa12 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 17 20:49:25 2024 +0000 Use inline in sn3d.h for exspec/sn3d shared variables commit 7acc0bef753bc0ab5502332726457bb54661e03c Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 16 13:26:58 2024 +0000 Revert "Update Makefile" This reverts commit 3d3e3295c66fdf50920d638f339b016ebd5e7e2f. commit 31038fdbfbd73e121f7ecc760e97ff85d84a87c8 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 16 13:26:56 2024 +0000 Revert "Update update_packets.cc" This reverts commit c4bc2750f95e11314ad86cda9b406c85736235a6. commit c4bc2750f95e11314ad86cda9b406c85736235a6 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 16 13:15:54 2024 +0000 Update update_packets.cc commit 3d3e3295c66fdf50920d638f339b016ebd5e7e2f Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 16 13:10:41 2024 +0000 Update Makefile commit 0142634b9645a696556d6db714fd7763fc3fd0d9 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 18:02:46 2024 +0000 Update ci-checks.yml commit d69686cbe6228b7b1003acebee2ede834ef16a83 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 18:00:50 2024 +0000 Update ci-checks.yml commit b5006017178105037354cad7daea83df6b4ee42c Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 17:57:52 2024 +0000 Update update_packets.cc commit 68fc952a411cac2c909afd1662de0785766e023a Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 16:48:44 2024 +0000 Update ci-checks.yml commit 55c136f04bcf4ec6eb620df4c762b52db72eb6bd Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 16:26:01 2024 +0000 Rename pkt_ptr to pkt (now using references) commit d2f052c73ac3b5647bdb47704c13f5c92dd48cab Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 16:21:50 2024 +0000 Update update_packets.cc commit 77f0c6cf6d9f1e7dfd9ab02936d7a3bfda3b3eb2 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 14:13:38 2024 +0000 Update update_packets.cc commit 5b323098797bcd6075e4074f2aa89a2b7f7950dc Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 14:05:33 2024 +0000 Update Makefile commit e1ac2a3d5494f1cd7e16beb5818b5ad84c82ec01 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 13:59:54 2024 +0000 Update update_packets.cc commit baa0278dde74a330649ecfc1a5aa83c0d30b2e41 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 13:38:36 2024 +0000 Update packet.cc commit 9966eb74e8c5fa6657cbbed614174d45c1cc1494 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 11:51:47 2024 +0000 Refactor check_already_running() commit ca32b5b1b6d79676eb26f927a6ad7c95dc3d3141 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 11:31:26 2024 +0000 Update update_grid.cc commit e8759c1bc841754e2ae0d529ca2d2bbf3ea1a921 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 11:24:49 2024 +0000 Replace get_ionestimindex() with get_ionestimindex_nonemptymgi() commit 19ff955c1f0924b9458c8a0620ef3d48fbcdc3c8 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 11:01:24 2024 +0000 Update rpkt.h commit aa3d1c1f4f1cc4f19190e12701588fecbd6456e8 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 10:54:45 2024 +0000 Update exspec.cc commit 8767304a4cad1a7575158b05e99e4302b2156ad2 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 09:52:04 2024 +0000 Update packet.cc commit f314834fac04c5548ae636fc332541bdfd5d362f Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 09:49:14 2024 +0000 test std::views::iota commit 026e9ead99ddf651afaf6fb76c5fc9b572a6fa64 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 09:33:29 2024 +0000 Fix lint warnings commit 7b6ebf12ee943d1e87bdbe0773d470d82c31cbce Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 09:20:20 2024 +0000 Update Makefile commit a701844cb5d98ae678592267857300b2cf5a0b37 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 09:20:03 2024 +0000 Update sn3d.h commit 0bca01d7e705bb3d5a6f0cc980883c123d2002e0 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 09:16:15 2024 +0000 Update nonthermal.cc commit 8eed3202acfd57e4b905aa648653cb791b088614 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 09:08:46 2024 +0000 Update decay.cc commit 0bbbf6447dcd02668587fe93881bf2997b71e5c7 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 09:06:14 2024 +0000 Update decay.cc commit 5e46478871cc1ace96553cc909625df6aea3e89a Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 09:01:06 2024 +0000 Update stats.h commit 01ae9abd58347836cba58511d95173b6e193c024 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 08:55:12 2024 +0000 Update stats.cc commit 8ca000ed8b9fa66fb316cf9212388be63c78439b Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 08:51:43 2024 +0000 Update kpkt.cc commit 6e7ab79749e36f5783dd3e6aef301a9f5f737a19 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 08:48:15 2024 +0000 Update to clang-format 18 commit 7a8afb13acce0409d6bdda322f774188eae1df6d Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 08:46:34 2024 +0000 Update ci-checks.yml commit 2a37c38d026bcb16ff9c4c6c62bc97a589dc773a Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 15 08:45:22 2024 +0000 Update .pre-commit-config.yaml commit 908eda8da15b5a4b9bdcd9bce1f856f80211ed52 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 22:26:56 2024 +0000 update md5 classic 13 commit 346b9309287a4fff527890826d577dcc70f32412 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 22:25:23 2024 +0000 Update sn3d.h commit ec6294c77fc3e313d0027f279ec0f0edea23e9f8 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 22:19:32 2024 +0000 Update radfield.cc commit 7beb4f7ab188603ed262b47b8c64b596450da994 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 22:11:00 2024 +0000 refactor radfield::zero_estimators() commit e93333cdf3b15584554ec1aedb7f91379a864cee Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 22:05:22 2024 +0000 Change set_J_normfactor param modelgridindex to nonemptymgi commit 63be56dca7f85c4971d2a52883168e03b11e1df0 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 22:03:16 2024 +0000 Update radfield.cc commit a5ccbe5fc26c504a6066448f370f0e8d69ab9044 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 21:58:40 2024 +0000 Update checksums for thread_local rng commit bb69f7a05b46a3045b1731789cad19cb511f219b Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 17:40:13 2024 +0000 Use brace initialisers commit 26009eebf9fcf6aceb5d01fa7d90f3062f4ec594 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 17:37:15 2024 +0000 Update sn3d.h commit e9d1bab7f89a82c3bd6de8cc2f8b10626b00dcad Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 17:36:57 2024 +0000 Update input.cc commit 7b7374e7aa868c51906296b91aaf92d4444ce473 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 17:35:16 2024 +0000 Use thread_local std::mt19937 commit 122683d830f4d33a3896d20733273824cddbd596 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 17:00:09 2024 +0000 Update Makefile commit 733706f72d394728f2249c54a3276a5a1f9f9e2f Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 16:51:29 2024 +0000 Update Makefile commit 2001fd4aefedee40691b7de962c1a24317fe4fc9 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 16:46:35 2024 +0000 Update ci-checks.yml commit 36f2d6c24409c578f97df48c8c46e8a6cca8e7a2 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 16:41:26 2024 +0000 Update ci.yml commit 2d07cdb399a1ae35884be77ba60bc7d9288c8ab3 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 16:40:16 2024 +0000 Update Makefile commit 64c773ba8095ec382c03489f67bf0f63bb7f1244 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 16:33:36 2024 +0000 Update Makefile commit d5e2b12974b276ff76489fef04b04615c1968217 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 16:26:52 2024 +0000 Set MPI ON or OFF based on whether mpicxx exists commit f22e6aea132b88accae4547d27b4e0d392e2d0aa Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 16:04:41 2024 +0000 fsanitize=address,undefined commit 467307b9c7187ca2c4e9372beccea5a2d1946a89 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 15:54:10 2024 +0000 Update ci.yml commit ef4271dcc46263cd088b7d70e61e55f25599deec Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 15:49:56 2024 +0000 Remove rng_init() commit a767c1a90ce340dd5c9c3e61c9a38458864003fc Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 15:48:55 2024 +0000 Update grid.cc commit 39a14c041e7b1ad3b0091d498d08ab3d70232e41 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 15:37:30 2024 +0000 Update Makefile commit 8114447e00d851df6d2ed0ec0871a8b33ec0639d Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 15:27:07 2024 +0000 try disable address santizer commit 3c8dfe493791047c0a81bf670683e7803fe99408 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 14:57:15 2024 +0000 Update ci-checks.yml commit 1b98da9623f54c669d5f5c0327d26d2eb0fc83ea Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 14:52:12 2024 +0000 Update ci-checks.yml commit ab2d6d8ea5f2ecd639457eb9af7dafa5821ab106 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 14:37:07 2024 +0000 Update ci.yml commit e14b588c6751cad6690ad2bc5b86afbb267e9106 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 14:36:52 2024 +0000 Update ci.yml commit 6fb10eb460044c3c91a9150bef47613df3ba08be Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 14:35:21 2024 +0000 Update ci.yml commit 6a1ac31d477690b80dae49a078fda39a2b0aa79f Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 14:29:15 2024 +0000 Update nltepop.cc commit 1f2daff2679829bd6059d0e78530572c1dd5d67e Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 11:55:03 2024 +0000 Update nonthermal.cc commit 1b228dda28dc0a47a08e6064060ee788bbb107a2 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 11:52:22 2024 +0000 Remove get_num_threads() commit 3c756431b5058d2f8b6e8101ac2e0c1bf5767c2e Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 11:50:54 2024 +0000 Update grid.cc commit c290515d2ed079a046e8fdbebc44a527ba62be95 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 11:44:20 2024 +0000 Remove global tid commit 917da40b24e520900498e55a42d127929f738e9e Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 11:37:10 2024 +0000 Update input.cc commit fba2a5461585a7c98f0af1f19d465e7f99c45385 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 11:29:59 2024 +0000 Update stats.cc commit 146d1dc193e09fbec421690f5646ae9881b3e2cb Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 11:17:55 2024 +0000 Revert "Use atomic for eventstats" This reverts commit b527da02d500367e79c3c5ef19548eba53c917ea. commit b527da02d500367e79c3c5ef19548eba53c917ea Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 11:11:19 2024 +0000 Use atomic for eventstats commit 87ce37656e229be8a85d06a6c978d0cc947228fa Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 10:47:46 2024 +0000 Update rpkt.cc commit b691ac424f482a98b9f1e224a45d6bc2e8d23a10 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 10:47:38 2024 +0000 Update exspec-gzip-juwels.sh commit 09d0a718d8fe45fcec4c6d2bc1e751b7ec58580a Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 14 10:46:19 2024 +0000 Remove obsolete comments commit 42db6469e19b377f198bafcaeee65b7243db1e31 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 13 11:12:51 2024 +0000 Update artis-juwels.sh commit 68277beced1a3ba4ccbe0df3c1744700096fae4b Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 13 10:09:19 2024 +0000 Generate ramdom seed on rank 0 and broadcast commit 34f38f55bb646a280971a0580587f64fa7a67086 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 12 16:47:01 2024 +0000 Fix enum to int conversion commit 46d977f64da620979716b9e12a4406b63070265c Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 12 16:25:09 2024 +0000 Update artis-juwels.sh commit 2cfe5c0e109150cc4d61b47cc9ae617ff76d4d4b Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 12 16:07:34 2024 +0000 Condense node rank log messages commit 34ac33409d5115c2b3a4bc2b845ba29942a4907a Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 12 13:26:48 2024 +0000 Update artis-juwels.sh commit 35fbc133420fe04c5efbdc8133bce1c9aa25bf76 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 12 13:25:29 2024 +0000 Update Makefile commit b0025e2da72c907a6136a7db1e52595a0042b715 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 12 12:57:40 2024 +0000 Update artis-juwels.sh commit 426c4e9b52475e69fe85e95a50b13b6b3cb11576 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 12 12:56:46 2024 +0000 Update exspec-gzip-juwels.sh commit 0ebbe19d4487d9aa16479c2c7a720b6e9d3331b9 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 12 12:56:03 2024 +0000 Update jobscripts commit 84369b4926c3e41ee4348fe0156b61610a202a67 Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 11 15:27:29 2024 +0000 Update gammapkt.cc commit 5d47cdaf5db6037361ec5969a7f8fc282f00a5bc Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 11 11:26:15 2024 +0000 Update artis-juwels.sh commit bc1f3d17c5526b20959262d16857c4a87588c77c Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 11 11:09:52 2024 +0000 Set ncoolingterms extern linkage commit bc4ccf921ea906a27b7ce1a71375499dc2e27782 Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 11 10:16:11 2024 +0000 Update artis-juwels.sh commit 31694f207398d96bc9e7408c00e91a5b6c96cc52 Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 11 08:35:27 2024 +0000 Update artis-juwels.sh commit 0f704e6d193d444351f7c65f0cca572883e97419 Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 11 00:58:56 2024 +0000 Update artis-juwels.sh commit 6ff80dde2061e7506ab9e2f2fac1afc97792d466 Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 11 00:50:00 2024 +0000 Update artis-juwels.sh commit 77aa62def49428981e32e3a257befb0aa06ab77f Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 11 00:45:52 2024 +0000 Update artis-juwels.sh commit 01c0382336984ee8b763d37188e9ff9b54fb0943 Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 11 00:41:16 2024 +0000 Update artis-juwels.sh commit b41d83c865762e85e86f4a7560b23644185f42a8 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 22:49:21 2024 +0000 Update macroatom.cc commit d5c519a711aa1685d77b82404c7e66e4b971a46b Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 22:39:04 2024 +0000 Update macroatom.cc commit 89c065f94b74953e1d5add14b3597028bec4f681 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 22:37:36 2024 +0000 Update macroatom.cc commit a49181cefd3fa95dda31859c0746c5d2fd4f196a Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 22:36:37 2024 +0000 Update rpkt.cc commit cc7a2edc713b0f6db71632fab4a5bfbbf788f983 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 22:36:24 2024 +0000 Refactor commit 27b575051f04aa175ac26a4dfe2e7eabd3143a92 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 22:33:27 2024 +0000 Remove obsolete comments commit 6882ef2e9a2a3b23342e7d04d8438eaad436cf81 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 22:25:39 2024 +0000 Update sn3d.cc commit 216a8dbcac89b5f3f39dcdfaf64c3454f0288959 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 22:21:16 2024 +0000 Revert "Update sn3d.cc" This reverts commit 3751ef44f6b4ed0fe0251f1027132385384ba2a9. commit e9dfb2ab4470d062b7b0b1bcac05567366ac5f5d Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 22:21:13 2024 +0000 Revert "Update sn3d.cc" This reverts commit 4d2023b4caffbef7d11e15b642de6f98cbf60ebd. commit 4d2023b4caffbef7d11e15b642de6f98cbf60ebd Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 22:13:00 2024 +0000 Update sn3d.cc commit 3751ef44f6b4ed0fe0251f1027132385384ba2a9 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 22:03:45 2024 +0000 Update sn3d.cc commit 4488ba2f6b08396f9305511d8a7bec4a7a45f8ea Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 21:56:17 2024 +0000 Update rpkt.cc commit a263d0c12b256b0583e0019f9f8c9963553eddfd Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 21:53:06 2024 +0000 Update thermalbalance.cc commit fbc42b5894a70bc7f82bc9f5d22d279e10c0b206 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 21:51:56 2024 +0000 Remove obsolete comments commit 5eaab199c3192736c91140ffd40e01e5dfc673f5 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 21:41:26 2024 +0000 Update update_grid.cc commit 3010c7b3bcc25629bda5e9eb81f747364f0fa25d Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 21:26:43 2024 +0000 Move bfheatingcoeffs into thread_local of solve_Te_nltepops() commit d882f7bb4a43144daf6226625c7a6ce1441a4a10 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 21:01:52 2024 +0000 Update update_grid.cc commit b2498ca93ca0f8249e6616fdea7233b931f98d63 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 08:34:13 2024 +0000 Fix clang-tidy header warnings commit 6a825319ec5ccfec13b83f2747fc96a657bdb518 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 08:15:01 2024 +0000 Update ratecoeff.cc commit 12f6a2ba33f516056470f4e4e936222cd1580a11 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 08:14:22 2024 +0000 Update ratecoeff.cc commit c9d15dbceffd7f2cd5e4a4f272728e5f2e92d3f5 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 08:05:33 2024 +0000 Update sn3d.cc commit 428c9dc99947c57fd9a6dfa375967065053987a1 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 08:00:28 2024 +0000 Update update_grid.cc commit 3f4ffeea7104e1c93949453f62e6bebdd5aa9aa9 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sun Mar 10 07:56:12 2024 +0000 Update update_grid.cc commit 42de7f300eb057ff91f89cd7b9d63db2631499e7 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 9 13:41:04 2024 +0000 Update rpkt.cc commit a9d8437ec2aeb39d6961b16b487fd30c2da7e21b Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 9 13:39:02 2024 +0000 Update sn3d.h commit 3313b158eff6c471fcbc9956162472d3d8f5feae Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 9 13:29:58 2024 +0000 Remove unused globals::startofline commit f72debe171c4a90ab7b687a9060407edd2c36e39 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 9 11:42:41 2024 +0000 Update checksums for gamma estim write out commit 60f6378bf0dec2c85b09a86261fa4f53a58ffa42 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 9 10:13:08 2024 +0000 Write corrphotoionrenorm and gammaestimator for thick cells (might not have been thick during grid update) commit db55d924ae32602925a8fd003edd312f304c41eb Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 21:27:01 2024 +0000 Update globals.h commit 35e27fea4c2a996aa88fd2243effd9033e09c961 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 21:18:01 2024 +0000 Fix circular header dependency commit e5c9fb5601339c56773893861708e16707e8002c Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 20:57:23 2024 +0000 Revert "Update rpkt.cc" This reverts commit f857540021c116cc8c2e45d7d97ef9c84b15630f. commit 9bc5c79ad28aaf7e644de2ccddcff18a22120f65 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 20:57:09 2024 +0000 Only update J and nuJ estimators in thick cells commit 9c02a01913f36bee767f7c126a1428445e9e8310 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 20:55:57 2024 +0000 Update checksums for no gamma estimators written for thick cells commit 780f72ea649aa7270c5eab498390d763376c703d Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 20:33:48 2024 +0000 Avoid writing unused corrphotoionrenorm and gammaestimator for thick cells commit f857540021c116cc8c2e45d7d97ef9c84b15630f Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 20:28:58 2024 +0000 Update rpkt.cc commit f0ab2ea57f523a1d52cd54bb7943c5b5150bee69 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 17:06:13 2024 +0000 Update rpkt.cc commit 75f949b2f7f5acfeafff7db3219d29e3353c91e0 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 16:13:52 2024 +0000 Update rpkt.cc commit bd7f6fbecc19904b224af0c47bd965ab0f54e8ab Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 15:37:52 2024 +0000 Fix cppcheck style warnings commit bef8305d0174620b6f21e9f0f435c3b70e32b054 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 15:28:41 2024 +0000 Fixup commit 86f92daf9798f55d0e4983d5e97333e6f82c711a Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 15:21:43 2024 +0000 Drop struct keyword commit c34bbf6765c712d018c8b49a4fed1cd36311df01 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 15:08:37 2024 +0000 Use TitleCase for structs commit 84f62b0bc0f0e18387a43d7a8b0093c86bf105ab Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 14:44:14 2024 +0000 Update grid.h commit 7d2734a13647d61de50580dd5f7d9c520232c881 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 14:42:55 2024 +0000 Update grid.h commit e57a85d1f8e03c805948cace2a098d20dc18e3fe Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 14:28:10 2024 +0000 Use TitleCase for struct Packet commit df06a74196ba07d568e42015f16f5945198806d2 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 14:17:07 2024 +0000 Use references instead of pointers for packets commit cfa28ef4640f88a0ac4b11a7dd05196d335c6415 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 14:05:59 2024 +0000 Determine usecellhistupdatephixslist from phixslist != nullptr commit a78154f885323824b8d65fd01c85f5fa559f48a7 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 13:58:04 2024 +0000 Make calculate_chi_bf_gammacontr static in rpkt.cc commit 4abd143e1a4afd130e3e75b8df4238f9b0a93f08 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 13:51:17 2024 +0000 Fix style warnings in mergeangleres.py commit a4153689d7013dea495431d7a0747e2f0a65917c Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 13:48:30 2024 +0000 Update exspec-after.sh commit 4d7a7341df06fcfa6478f3b3ed3e2f3e5b78f42d Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 12:10:59 2024 +0000 Update rpkt.cc commit ddb805c7671d73049e201e473055fb010c9e2eef Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 12:00:05 2024 +0000 Make ncoordgrid and coordlabel static in grid.cc commit 21ee683c8e3b5d3380c375b5f1fef47416b9586c Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 11:56:15 2024 +0000 Update grid.cc commit 5d4e968287f07febad335b1e6803c961aefe8c0b Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 11:55:37 2024 +0000 Update grid.cc commit 86527eead8beb13e25d0cc56559b3fc6bd5d2204 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 11:54:33 2024 +0000 Update grid.cc commit 37c0995ae0ab58a8bcd9d71e7c1047568e62d206 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 11:41:39 2024 +0000 Update rpkt.h commit 6bf3a422c9b90040d47f0710167991d329045840 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 11:39:16 2024 +0000 Make bflist a std::vector commit bb07875b4a0a9ea7da8f8385d14a06ec0e721505 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 11:37:46 2024 +0000 Update rpkt.cc commit aaf2527b90402582a732ac7c93dc536a76f5c635 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 11:32:38 2024 +0000 Update sn3d.h commit f03ef0c66be9652c469aef8cc3a03d8b9851af37 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 11:27:24 2024 +0000 Update results_md5_job0.txt commit ef10f281c415911a305845919e3846ee7b849055 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 11:14:43 2024 +0000 Make bfrate_raw a std::vector commit 73ca7c36f1bba0d7b50083252c41787bff58852f Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 11:00:44 2024 +0000 make globals::allcont_nu_edge a std::vector commit 56533325b9be7491f11e1f5752a753f2401095d0 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 10:57:13 2024 +0000 fix omp threadprivate location commit 89f01070bf728f99ee4d906bdddd1b148a73c006 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 10:49:27 2024 +0000 Update rpkt.cc commit 1708855fc5669293bd77232043e42f9e72318c07 Author: Luke Shingles <luke.shingles@gmail.com> Date: Fri Mar 8 10:44:37 2024 +0000 Update sn3d.h commit 0f63a59c755d8d6a59dd86323a23bcfec9c9e40b Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 17:59:01 2024 +0000 Avoid printout in calculate_chi_bf_gammacontr loop commit 63451909c668f791c3582f01f63c1baa720250e8 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 14:53:36 2024 +0000 Update checksums for printout change commit 43bb7c245757b80e723a15838361df6604b457f8 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 14:20:00 2024 +0000 Update sn3d.h commit 652bd5a812cb58f11d1529062b965e497851f506 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 14:06:22 2024 +0000 update classic 3d checksums for bugfix commit fa6f9d79ec69485d1254a3e63f84fdb61022cdaa Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 13:32:43 2024 +0000 Update rpkt.cc commit 15e9a8883c92f9ec2c00a25a7581db6a0cb86e1c Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 13:22:19 2024 +0000 Update checksums for bugfix commit d52ea41c87a649a661c569ec5728a5e015f97c4c Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 13:17:11 2024 +0000 Update rpkt.cc commit 454b07fc9a8790be37543221e355a74f86e1a0a5 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 13:16:45 2024 +0000 Update rpkt.cc commit adc2b28728c19163a2c6e9af69bbfd67423074bb Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 13:16:15 2024 +0000 Update globals.h commit 438560161961b1dad9fdffe85c0f7c7903eb9ecf Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 13:15:43 2024 +0000 Update rpkt.cc commit 99077197a9535871bce6e6a4d5f3148445b4cd0c Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 10:19:24 2024 +0000 Update decay.cc commit 060fea2b3c465d67fe23503f8e1daac6b1fd63e7 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 10:14:59 2024 +0000 change static constexpr to inline constexpr commit 89fc95c96005c2399f122e88f87ea00d5a0131a4 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 10:08:01 2024 +0000 Fix includes commit 40f86dd0fcce06dd05311ffde509ba4a3a0dd4c1 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 10:03:34 2024 +0000 Use std::string for decay::get_elname() commit 725121cef8f202185d43b404fcb80e2fd7b71f01 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 09:44:39 2024 +0000 Update decay.cc commit 6760fed6e10994a55e7e74cca969d255d0229d70 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 09:29:11 2024 +0000 Update kpkt.h commit ec6fe2b6519630e82ccb638086760640fec4c0fb Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 09:28:53 2024 +0000 Fixup commit e23aafed0d5211ee6194d9cccba7f6150bce2af1 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 09:25:04 2024 +0000 Hode kpktdiffusion variables in kpkt.cc commit f1d14b422196a854c199ad755a3a7d9775a419ed Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 09:18:47 2024 +0000 Update ci-checks.yml commit 4dd39c7225c3bcacb817ddefa5847ff1c9050bb3 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 09:14:50 2024 +0000 Use more static 2 commit fda8d1797e06ef8cb0d3eacb63ebb0cfa2d9de80 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 09:09:34 2024 +0000 Use more static storage commit 7eddd60a343fed2cd848bf5aad8811b34cf84807 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 08:41:49 2024 +0000 Update ci-checks.yml commit ef204150f767069cd961df80baeb5fdd054806c9 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Mar 7 08:27:11 2024 +0000 Make constexpr constants inline commit 161a0dd5a10c4ebbec32ff028fb56d973dfb96bc Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 6 11:10:40 2024 +0000 Update classicmode 1d checksums commit 2bfe6028b0f58fd48eecf1f39ca8092f251c89b7 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 6 10:24:46 2024 +0000 Fixup commit afa149149ec116027d580e1c356145eaf288bc53 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 6 10:24:09 2024 +0000 Move phixslist and chi_rpkt_cont into do_rpkt_step() commit 09d03d4f86f0bbd2a75ca06baa35577c61393abb Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 6 10:20:29 2024 +0000 Update radfield.cc commit a3c3fb168aff664f0b6def8632faca4f14e539e2 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 6 10:12:33 2024 +0000 Test removing global chi_rpkt_cont and phixslist_allthreads (use thread_local instead) commit ac1b3e5737455b6cfe968617e197445f2cda0050 Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 6 10:00:25 2024 +0000 Use clang-format 17 commit cda14a238a9e3853a2cb1c7230f0dffe0616bb9b Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 6 09:50:16 2024 +0000 Update radfield.cc commit 300940667250b252ae59725479fb8ae877810cac Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 6 09:28:12 2024 +0000 Update rpkt.cc commit 6f2eb3342c78d9793f349b6dcf9becbe4a0d82ea Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 6 09:26:53 2024 +0000 Update rpkt.cc commit c8177942315a4d18050d2de67956336bbf159f5b Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 6 09:25:42 2024 +0000 Update update_packets.cc commit 6d9cc5864ba7f9d3fd1bc91bbfe0de38e9987ffe Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 6 09:22:20 2024 +0000 Update rpkt.cc commit 2a1de7c967d945ee02f15cb587782a63bc1c4ece Author: Luke Shingles <luke.shingles@gmail.com> Date: Wed Mar 6 08:41:08 2024 +0000 Update classicmode checksums commit d8be190ff733fedb5720d1cea6aa1649a04c8d39 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 22:22:49 2024 +0000 Update rpkt.cc commit 6c2e587efa6d3931c955d669672582d6ecc0581c Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 22:14:44 2024 +0000 Update ratecoeff.cc commit e74c331d1a4eee18eabc87aee1dc66435346eaaa Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 22:13:12 2024 +0000 Pass phixslist to start enabling stdpar commit 79c0c0f26957e820d6f6c9ef9fb86875c8053a3b Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 21:39:09 2024 +0000 Update rpkt.cc commit cc4bcb11b0c30510896f36054c6e9dba9d7b2523 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 15:22:48 2024 +0000 Update stats.cc commit d2d7677334179f2e7dce9af449ab69f247596625 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 15:17:24 2024 +0000 Update stats.cc commit efa503ede481bc71540b35e7169005265a87f3ee Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 15:14:28 2024 +0000 Update checksums for round-off level printout change commit 3b63fc91fd0a25b8f18c3bea02b90d9d51f7ed5e Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 15:12:35 2024 +0000 Update sn3d.h commit 7c47ed38e192e338d94f42889623e21d81b3d02a Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 15:00:34 2024 +0000 Fix types for printout commit cd9632b44b7ce42c9002cd12d9e655ead129eeb5 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 14:50:49 2024 +0000 Fix seed data types commit f03b3170c01e3e2ffaf69039b630b3225e3209a7 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 14:37:05 2024 +0000 Fix macos gcc compilation error commit ee51d3201bb4a52b307bf3160ad8f554d4028110 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 14:34:15 2024 +0000 Revert "Revert "Fix printf codes"" This reverts commit d73104e0318d6d9512f806d00fb18fd20a29da9e. commit 8e4161961d07588c10d744dce7c533d25d7850f7 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 14:33:31 2024 +0000 Update sn3d.h commit 0e9afef9986084d6e5df4ba49ecd394af6074430 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 14:31:45 2024 +0000 Revert to printout macro for argument checking commit d73104e0318d6d9512f806d00fb18fd20a29da9e Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 14:22:49 2024 +0000 Revert "Fix printf codes" This reverts commit b40926317c433ee1633de6173a49b268ecce4f28. commit b40926317c433ee1633de6173a49b268ecce4f28 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 13:27:11 2024 +0000 Fix printf codes commit da620132c57d463bf6802aaa10da6494a441a950 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 12:28:17 2024 +0000 Update grid.cc commit 4b65e2933569cf92d9233183fe00f317cba55cec Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 11:53:41 2024 +0000 Remove std::format commit 415a83f7e9532f16d2a530f00e13fde72eabe9ba Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 11:49:23 2024 +0000 use std::format commit b4e7aa32d22deb564602b1a4290c9123952df238 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 05:53:33 2024 +0000 Update virtual packet checksums commit de3d37d3ef838cb0dbe23e2360be5d02dfcb3d87 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 05:43:31 2024 +0000 Allow virtual packets to pass through empty cells commit c1dbf0df2c121359c0f9cd08abe2ce66e486a140 Author: Luke Shingles <luke.shingles@gmail.com> Date: Tue Mar 5 05:42:05 2024 +0000 Update checksums commit 13e6ac7059a5208876c3c6f020d2cb1df29c44e0 Author: Luke Shingles <luke.shingles@gmail.com> Date: Mon Mar 4 16:08:32 2024 +0000 Fix virtual packet arrival times commit 63ef74e51ab42cdb83c541cd642a0a2b8403804a Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 15:35:39 2024 +0000 Update ci.yml commit 81ffeb787a16fee7d685aba2f2743725f2acc9a7 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 15:35:05 2024 +0000 Update ci.yml commit f12bd4c5834f5b530f14ccf6c67fea60e95aa10d Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 15:33:40 2024 +0000 Update ci.yml commit f9c3c3689edb341e21f9b617ca4b4ff63500597e Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 14:31:22 2024 +0000 Update ci.yml commit 76d1d7641e3744fa555f20d946baa87df2042ede Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 14:27:19 2024 +0000 CI: fix spectrum plotting commit a4110c2501bde83eaaf227a60dd5de2462dbdf3a Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 14:21:05 2024 +0000 Update ci.yml commit c066334095f811ed59ffc94d1f45456c927a61fa Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 14:13:10 2024 +0000 Update checksums commit a9e07d86e71cc2a74245ea8c6a56f16f1643875a Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 14:06:04 2024 +0000 Avoid using __builtin_unreachable with OPTIMIZE=OFF commit fb8deb115c4d6abb23c1586eabd44fc740b855a1 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 13:47:17 2024 +0000 Simplify printout commit 2a1a16276015a94c0a65a197ea7270ceedb74266 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 13:43:37 2024 +0000 use std::ofstream for output_file commit 4d4cf0436897e1534556a9805d4ef5e9de6d1c5a Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 13:15:27 2024 +0000 Update sn3d.cc commit 50aee1730353cafe1be4fdee3f6a69d7a883601e Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 13:11:57 2024 +0000 Update gammapkt.cc commit 0e206c64baf7ba6e83a96f4f64500082cfbb1433 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 13:08:16 2024 +0000 Update sn3d.cc commit 2926c9dd7dd07a6b1f122fa1971840ced8d750d0 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 13:06:19 2024 +0000 Update sn3d.cc commit 340b0cf5e6b57163545bcf4f05fe4b19449efefc Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 11:51:50 2024 +0000 Revert "Update sn3d.h" This reverts commit e4c552df4c02e87ebae5c76ae4004745bc711fc2. commit 91f0ed7aff10aee876c78b331e6f7aca6428d981 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 11:51:40 2024 +0000 Update results_md5_final.txt commit e4c552df4c02e87ebae5c76ae4004745bc711fc2 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 11:42:31 2024 +0000 Update sn3d.h commit f97f4a77f3802601ae7ad27d7e72f1456e9760d0 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 10:57:18 2024 +0000 Update sn3d.h commit 1052deca2d994b0489ced451121d330beb0939f3 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 10:55:09 2024 +0000 Update sn3d.h commit a6d40b71113153262093a46e87614af8a9717703 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 10:53:15 2024 +0000 Update vectors.h commit 1b7f875c79afae6ae8adf3402272a8fb8474fdae Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 10:28:28 2024 +0000 Update decay.cc commit fb578bdb50af9a495ee3ed644228937e432aa7ba Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 10:28:17 2024 +0000 Update sn3d.h commit d85da8b14e49991de21a06395d6a5ce4b02c43e8 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 10:22:23 2024 +0000 Update decay.cc commit df0663fe0a8ec8c8438e9348f5e460ef1a3b5e01 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 10:12:51 2024 +0000 Update sn3d.h commit 8a95b2a5ad9a82241eeeefa3f66adfe48d9ea349 Author: Luke Shingles <luke.shingles@gmail.com> Date: Sat Mar 2 10:11:54 2024 +0000 Update sn3d.h commit 59f6e35ab870c12c5bf6f86b7f16324003977450 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Feb 22 11:10:02 2024 +0000 Update ci.yml commit fecf0e415c7b6a954ef1a47d45536b77dcfe88a3 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Feb 22 10:22:49 2024 +0000 Update ci.yml commit 9a2ed5c8a6788554060007e903c46e28434255b6 Author: Luke Shingles <luke.shingles@gmail.com> Date: Thu Feb 22 10:21:18 2024 +0000 Update ci.yml
Merged
lukeshingles
added a commit
that referenced
this pull request
Apr 26, 2024
- Add VPKT_WRITE_CONTRIBS option to save all virtual packets contributions for later time and wavelength binning, with emission/absorption types by artistools. - Improve performance by enabling fast-math compiler options, constexpr radfield bins, improving bound-free estimator accumulation, removing storage for empty cells, and using node shared memory for initmassfracstable, elem_meanweight. - 3D AD2 (Shingles et al. 2023) 1e8pkt 1920 core JUWELS runtime decreased from 210k core hrs to 134k core hrs (1.56x faster). Memory per core decreased from 2.8GB to 1.5GB. - W7 (Shingles et al. 2022) nebular 960 core 2e9pkt 150-410d JUWELS runtime decreased from 13.6k core hrs (20230811 version) to 10.4k core hrs (1.31x faster). Compared to the 2022 published version with 18.6k core hrs, this is 1.79x faster. - With a Simpson rule integrator in place of GSL's adaptive method (producing identical observables) runtime decreases to 6.83k core hours, 1.99x faster than 20230811 and 2.72x faster than the 2022 published version. - subMch Shen+2018 nebular 960 core 1e9pkt 150-410d runtime decreased from 13.14k core hrs (20210417 version) to 7.30 kCore hours (1.80x faster). With Simpson rule integrator, runtime decreased to 6.07 k core hrs (2.16x faster) - sim2010 classic mode 2-120 days 2e7 960 core JUWELS runtime decreased from 3.81k core hrs (20230526 version) to 1.87k core hrs (2.04x faster). Compared to ARTIS classic with 11.45k core hrs, this version is 6.13x faster. - Reduce memory per core to enable future GPU support. All threads now share a single cell cache and operate on packets within the same cell. This may later be expanded to multiple cell caches to increase thread occupancy as memory allows. - Fix virtual packets for models with internal empty cells. Passing into an empty cell previously triggered instant escape. - Fix a 1e5 factor in free-free opacity for opacity case 5 (Tanaka Ye-dependent grey mode and line-by-line non-grey mode for kilonovae). This increased the 3D AD2 (Shingles et al. 2023) early luminosity by about 20%. The spectra are almost unchanged (except for being brighter) - Reduce noise in particle deposition rate estimators by contributing partial deposition of packet energy prior to Monte Carlo transition event (similar to gamma deposition rates from path estimators). - Add support for calculating and using expansion opacities. - Add option for #52 by Gerrit Leck - #47 by Josh Pollin - Add some fixes to hybrid LTE-NLTE mode by Christine Collins --------- Co-authored-by: gleck97 <86471143+gleck97@users.noreply.github.com> Co-authored-by: Gerrit Leck <gleck@lxbuild07.gsi.de> Co-authored-by: Josh Pollin <joshuapollin222@gmail.com> Co-authored-by: Christine Collins <ccollins22@qub.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.