Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolvable checks implementation #22

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

romanodanilo
Copy link
Contributor

Description

Addressing #15 #18, implement relative checks, test data and test code

How was the PR tested?

  1. Unit-test with sample data. All unit tests passed.

Notes
example output
entity

 <Issue issueId="0" description="Issue flagging when an entity is referred in a entityRef attribute but it is not declared among Entities" level="1" ruleUID="asam.net:xosc:1.2.0:reference_control.resolvable_entity_references">
        <Locations description="Entity at /OpenSCENARIO/Storyboard/Init/Actions/Private with id Vehicle 2 not found among defined Entities ">
          <XMLLocation xpath="/OpenSCENARIO/Storyboard/Init/Actions/Private"/>
        </Locations>
      </Issue>

variable

<Issue issueId="1" description="Issue flagging when a variable is referred in a variableRef attribute but it is not found within ScenarioDefinition" level="1" ruleUID="asam.net:xosc:1.2.0:reference_control.resolvable_variable_reference">
        <Locations description="Variable with id unknownReferenceForYPosition not found within ScenarioDefinition">
          <XMLLocation xpath="/OpenSCENARIO/Storyboard/Init/Actions/GlobalAction/VariableAction[3]"/>
        </Locations>
      </Issue>
      <Issue issueId="2" description="Issue flagging when a variable is referred in a variableRef attribute but it is not found within ScenarioDefinition" level="1" ruleUID="asam.net:xosc:1.2.0:reference_control.resolvable_variable_reference">
        <Locations description="Variable with id foo not found within ScenarioDefinition">
          <XMLLocation xpath="/OpenSCENARIO/Storyboard/Init/Actions/GlobalAction/VariableAction[4]"/>
        </Locations>
      </Issue>

Signed-off-by: romanodanilo <danilo@ivex.ai>
Signed-off-by: romanodanilo <danilo@ivex.ai>
Copy link
Contributor

@hoangtungdinh hoangtungdinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romanodanilo

@hoangtungdinh hoangtungdinh merged commit 8042f96 into develop Jul 9, 2024
7 checks passed
@hoangtungdinh hoangtungdinh deleted the danilo/add_resolvable_checks branch July 9, 2024 14:47
hoangtungdinh pushed a commit that referenced this pull request Jul 11, 2024
Signed-off-by: romanodanilo <danilo@ivex.ai>

Signed-off-by: romanodanilo <62891297+romanodanilo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants