Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scoped params filtering to parameter search #28

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

romanodanilo
Copy link
Contributor

Description

Following standard document reference, now parameter search takes into account local scope and only visible parameters

How was the PR tested?

  1. Unit-test with sample data. All unit tests passed.

Notes

Signed-off-by: romanodanilo <danilo@ivex.ai>
Signed-off-by: romanodanilo <danilo@ivex.ai>
@romanodanilo romanodanilo requested a review from patrickpa July 11, 2024 15:55
Copy link
Contributor

@patrickpa patrickpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romanodanilo

@romanodanilo romanodanilo merged commit a27d455 into develop Jul 12, 2024
7 checks passed
@romanodanilo romanodanilo deleted the danilo/add_scope_parameter_search branch July 12, 2024 06:57
hoangtungdinh pushed a commit that referenced this pull request Jul 30, 2024
* Add scoped params filtering to parameter search

Signed-off-by: romanodanilo <danilo@ivex.ai>

* Unused typing Dict

Signed-off-by: romanodanilo <danilo@ivex.ai>

---------

Signed-off-by: romanodanilo <danilo@ivex.ai>
hoangtungdinh pushed a commit that referenced this pull request Aug 1, 2024
Signed-off-by: romanodanilo <danilo@ivex.ai>
Signed-off-by: romanodanilo <62891297+romanodanilo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants