From 70296603ad73dd270cec01b3d7c2043b3b80756d Mon Sep 17 00:00:00 2001 From: Cole DeMan Date: Mon, 19 Apr 2021 10:55:58 -0300 Subject: [PATCH 1/4] fixed additional issues from comms 14 --- alouette.py | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/alouette.py b/alouette.py index 1c0b45e..6914858 100644 --- a/alouette.py +++ b/alouette.py @@ -491,8 +491,10 @@ def build_filtering(): step=5, style={"margin-left": "5px"} ) - ]), - html.Span(children=html.P(id="lat_selection"),className="wb-inv")], + ] + ), + html.Div(children=html.P(id="lat_selection"),className="wb-inv") + ], className="col-md-6" ), html.Div( @@ -541,7 +543,7 @@ def build_filtering(): style={"margin-left": "5px"} ) ]), - html.Span(children=html.P(id="lon_selection"),className="wb-inv")], + html.Div(children=html.P(id="lon_selection"),className="wb-inv")], className="col-md-6" ), ], @@ -581,7 +583,7 @@ def build_filtering(): style={"margin-top": "5px"} ), html.Div(id='output-container-date-picker-range'), - html.Span(children=html.P(id="date_selection"),className="wb-inv")]), + html.Div(children=html.P(id="date_selection"),className="wb-inv")]), ], id="cross-filter-options", className="", @@ -589,7 +591,7 @@ def build_filtering(): html.Div( [ html.Div([ - html.Span( + html.Div( [ html.Label( id="groundstations-text", @@ -607,7 +609,7 @@ def build_filtering(): ], className="drop_down", ), - html.Span(children=html.P(id="ground_station_selection"),className="wb-inv")]), + html.Div(children=html.P(id="ground_station_selection"),className="wb-inv")]), html.Div([ dbc.Alert(color="secondary", id="pos_alert", is_open=False, fade=False, style={"margin-top":"0.5em"}), ]), @@ -632,7 +634,7 @@ def build_filtering(): style={"margin-left": "5px"}, className="btn btn-primary" ), - html.Span(children=html.P(id="download_selection"),className="wb-inv"), + html.Div(children=html.P(id="download_selection"),className="wb-inv"), html.Div ([html.B(id="Download_limit")]), ], ), From 1fd43310652ef40163d05db64c1b51ffec48313a Mon Sep 17 00:00:00 2001 From: Cole DeMan Date: Mon, 19 Apr 2021 16:25:33 -0300 Subject: [PATCH 2/4] accessibility fixes --- alouette.py | 39 +++++++++++++++++++++++++-------------- 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/alouette.py b/alouette.py index 6914858..cb108c5 100644 --- a/alouette.py +++ b/alouette.py @@ -595,7 +595,7 @@ def build_filtering(): [ html.Label( id="groundstations-text", - htmlFor="ground_station_list", + htmlFor="ground_station_list_dropdown", className="control_label", ), dcc.Dropdown( @@ -604,10 +604,13 @@ def build_filtering(): placeholder=_("Sélectionner | Select"), multi=True, value=station_values, - className="dcc_control" + className="dcc_control", + label = 'Label test' ), ], - className="drop_down", + className="drop_down col-md-6", + role="listbox", + **{'aria-label': 'Select plotted value'} ), html.Div(children=html.P(id="ground_station_selection"),className="wb-inv")]), html.Div([ @@ -707,7 +710,7 @@ def build_stats(): html.Div( [ html.Label( - htmlFor='x_axis_selection_1', + htmlFor='x_axis_selection_1_dropdown', id="x-axis-selection-text", className="control_label", ), @@ -716,17 +719,19 @@ def build_stats(): options=x_axis_options, multi=False, value='timestamp', - className="dcc_control" + className="dcc_control", + label = 'Label test' ), ], className="drop_down col-md-6", role="listbox", - style={'max-width': '400px'} + style={'max-width': '400px'}, + **{'aria-label': 'Select x-axis'} ), html.Div( [ html.Label( - htmlFor='y_axis_selection_1', + htmlFor='y_axis_selection_1_dropdown', id="y-axis-selection-text", className="control_label", ), @@ -736,11 +741,13 @@ def build_stats(): multi=False, value='max_depth', className="dcc_control", + label = 'Label test' ), ], className="drop_down col-md-6", role="listbox", - style={'max-width': '400px'} + style={'max-width': '400px'}, + **{'aria-label': 'Select y-axis'} ), ], className="row", @@ -781,7 +788,7 @@ def build_stats(): html.Div( [ html.Label( - htmlFor="stat_selection", + htmlFor="stat_selection_dropdown", id="stat-selection-text", className="control_label", ), @@ -793,17 +800,19 @@ def build_stats(): ], multi=False, value='mean', - className="dcc_control" + className="dcc_control", + label = 'Label test' ), ], className="drop_down col-md-6", role="listbox", - style={'max-width': '400px'} + style={'max-width': '400px'}, + **{'aria-label': 'Select Statistic'} ), html.Div( [ html.Label( - htmlFor="y_axis_selection_2", + htmlFor="y_axis_selection_2_dropdown", id="stat-y-axis-text", className="control_label", ), @@ -812,12 +821,14 @@ def build_stats(): options=y_axis_options, multi=False, value='max_depth', - className="dcc_control" + className="dcc_control", + label = 'Label test' ), ], className="drop_down col-md-6", role="listbox", - style={'max-width': '400px'} + style={'max-width': '400px'}, + **{'aria-label': 'Select plotted value'} ), ], className="row", From adf08bec631522c9b4cf3ca8701df4aa4a93be31 Mon Sep 17 00:00:00 2001 From: Cole DeMan Date: Mon, 19 Apr 2021 16:32:21 -0300 Subject: [PATCH 3/4] contrast fix --- assets/compiled.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/assets/compiled.css b/assets/compiled.css index ba7479b..b15d142 100644 --- a/assets/compiled.css +++ b/assets/compiled.css @@ -280,6 +280,11 @@ select { font-family: inherit; font-size: inherit; /*https://stackoverflow.com/questions/6080413/why-doesnt-input-inherit-the-font-from-body*/ } + +.Select-placeholder{ + color: #000000; +} + /* Removes awkward default styles on some inputs for iOS */ input[type="email"], input[type="number"], From 6113811f803963469b971019b8608cf5eb174f1f Mon Sep 17 00:00:00 2001 From: Cole DeMan Date: Mon, 19 Apr 2021 16:33:13 -0300 Subject: [PATCH 4/4] fixed a css error --- assets/compiled.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/compiled.css b/assets/compiled.css index b15d142..329d6ae 100644 --- a/assets/compiled.css +++ b/assets/compiled.css @@ -202,7 +202,7 @@ input[type="button"] { padding: 0 30px; color: #f2f2f2; text-align: center; - #font-size: 11px; + /* font-size: 11px; */ font-weight: 600; line-height: 38px; letter-spacing: 0.1rem;