Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes #104

Merged
merged 10 commits into from
Apr 26, 2021
Merged

Bugfixes #104

merged 10 commits into from
Apr 26, 2021

Conversation

coleweusthem
Copy link
Contributor

merging to the correct branch this time

@nfee006
Copy link
Member

nfee006 commented Apr 26, 2021

Approved for #99.

I believe that we still need something for #101 before merging this one, right? Or am I able to merge and #103 can be another pull request? I'd like to have a master version that's compatible with the new App-Launcher so that I can test on @ data at some point.

@coleweusthem
Copy link
Contributor Author

@nfee006 they should all be good to merge now

@nfee006
Copy link
Member

nfee006 commented Apr 26, 2021

Ok, great. Just as long as #103 is still on your radar.

@coleweusthem
Copy link
Contributor Author

@nfee006, I'm going to upload the newest version of dash core components here. You might run into an issue without it

@nfee006 nfee006 self-requested a review April 26, 2021 19:03
@coleweusthem
Copy link
Contributor Author

dash_core_components.tar.gz

@nfee006 nfee006 merged commit ac038b7 into Development Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfee006 nfee006 nfee006 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coleweusthem @nfee006