Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove semantic release single-commit rule #883

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

jthegedus
Copy link
Contributor

@jthegedus jthegedus commented Sep 14, 2023

Summary

As with asdf-vm/asdf#1642

GitHub now supports, and we use, the setting which sets the squash commit message the PR title.

image

Since this is now the case, we no longer require single-commit-PRs to have those single commits match the Semantic PR settings.

This will mean the errors from Semantic PR only apply to PR titles and are therefore easier to fix than the single-commit commit message.

Why

I noticed this unnecessarily tripping some people up across the repos. Eg: #882

@jthegedus jthegedus requested a review from a team as a code owner September 14, 2023 15:36
@jthegedus jthegedus merged commit 9b5378c into master Sep 14, 2023
4 checks passed
@jthegedus jthegedus deleted the ci-remove-semantic-pr-single-commit-rule branch September 14, 2023 15:37
@jthegedus jthegedus mentioned this pull request Sep 14, 2023
3 tasks
mbutov pushed a commit to mbutov/asdf-plugins that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant