Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: plugin list exit code 0 when no plugins are installed #1597

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix!: plugin list exit code 0 when no plugins are installed #1597

merged 1 commit into from
Jul 26, 2023

Conversation

hyperupcall
Copy link
Contributor

Summary

Closes #903

I do not consider this a breaking change because the fixed behavior falls into line with existing package managers. If one needs to test if no packages are installed, the better option is to parse standard output.

@hyperupcall hyperupcall requested a review from a team as a code owner July 14, 2023 22:45
@hyperupcall hyperupcall mentioned this pull request Jul 15, 2023
Merged
@jthegedus
Copy link
Contributor

jthegedus commented Jul 26, 2023 •
edited
Loading

Same reasoning in the other PR. Exit codes and formatted outputs from commands are our public API contract. I would consider this breaking. Happy to discuss in depth in a specific issue about what is breaking vs not, but in the short term I am pretty well convinced that exit codes changes are breaking changes.

jthegedus
jthegedus approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This probably should have broken a test or two 😅

@jthegedus jthegedus closed this Jul 26, 2023
@jthegedus jthegedus reopened this Jul 26, 2023
@jthegedus jthegedus changed the title fix: plugin list exits 0 when no plugins are installed fix!: exit with status code 0 for plugin list when no plugins are installed Jul 26, 2023
@jthegedus
Copy link
Contributor

Bumped the wrong button, sorry 😅

@jthegedus jthegedus changed the title fix!: exit with status code 0 for plugin list when no plugins are installed fix!: plugin list exit code 0 when no plugins are installed Jul 26, 2023
@jthegedus jthegedus merged commit a029c00 into asdf-vm:master Jul 26, 2023
8 checks passed
@hyperupcall hyperupcall deleted the hyperupcall-fix-plugin-list-exit-code branch July 26, 2023 12:12
@hyperupcall
Copy link
Contributor Author

Same reasoning in the other PR. Exit codes and formatted outputs from commands are our public API contract. I would consider this breaking. Happy to discuss in depth in a specific issue about what is breaking vs not, but in the short term I am pretty well convinced that exit codes changes are breaking changes.

I don't really feel very strongly about it in this particular case, so making this breaking is definitely fine by me

@p-linnane p-linnane mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tony-sol tony-sol tony-sol left review comments

@jthegedus jthegedus jthegedus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asdf plugin list should return a 0 exit code when no plugins are installed
3 participants
@hyperupcall @jthegedus @tony-sol