Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nushell): Use def --env instead of def-env #1681

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Nov 20, 2023

Summary

Nushell recently deprecated use of def-env. Migration is clear. This issue implements the deprecation and this issue implements def --env. It states:

Because def-env is used everywhere, including virtualenv, I propose the following steps:

  • 0.86: Add this PR, keep def-env and extern-wrapped unchanged.
  • 0.87: Add deprecation warning to def-env and extern-wrapped but keep them working.
  • 0.88 (or later): Remove def-env and extern-wrapped.

So, the minimum version needs to be bumped to 0.86. Unfortunately, this means older versions will no longer be support, but it is difficult as nushell has many backwards incompatible changes being made

Current version of nushell is 0.87.0, which was released last week. To ensure this fix gets merged before the release of 0.88.0, it should be merged before ~December 13

Closes #1680
Closes #1700

@hyperupcall
Copy link
Contributor Author

hyperupcall commented Nov 20, 2023

@jthegedus @Stratus3D this is an urgent bugfix. When the latest version of nushell is released in a few weeks, asdf will break without this patch.

Aside: Will it be possible to review my other PRs as well?

@acidghost
Copy link
Contributor

@jthegedus @Stratus3D ping.

Nushell 0.88 has been released with def-env removed, meaning that asdf cannot be used from nushell.
Can you please merge this PR and release a new version of asdf?

@hyiltiz
Copy link

hyiltiz commented Dec 25, 2023

This is a minimal change that has no impact to any part of asdf core mechanics and only updates asdf autocomplete interface for nushell. As of the last few updates, the script shipped with asdf simply throws a syntax error in nushell, as def-env is now an undefined symbol. Please merge asap.

@jthegedus
Copy link
Contributor

jthegedus commented Jan 9, 2024

@hyperupcall GitHub is not letting me modify this PR because of the source fork permissions so I cannot resolve the conflict (Fish version update), can you update this when you have the time? Thanks

@jthegedus
Copy link
Contributor

Thanks

@jthegedus jthegedus merged commit 3b8f400 into asdf-vm:master Jan 13, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: nushell def-env is deprecated
4 participants