Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR-6293 Add storage for querying CMR #30

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Conversation

reweeden
Copy link
Contributor

@reweeden reweeden commented Dec 6, 2024

Adds a new storage type for making HTTP requests via requests. There is also a convenience class with a few special parameters that are intended to make passing the CMR configuration a bit nicer.

In order to make this actually usable we also needed to add some way of injecting dynamic values into the objects returned from the source configuration. We implement that internally with a new class called ContextValue which is a placeholder containing a jsonpath where a value should be pulled from the Context object.

The syntax we use for defining a context value in the source config is a $ at the start of a string. This can be escaped like this $$ in which case the string will be interpreted as a literal string starting with a single $. For example $.meta.foo will become a ContextValue(path="$.meta.foo"), however $$.meta.foo will become the string $.meta.foo.

@reweeden reweeden force-pushed the rew/pr-6293-cmr-storage branch 14 times, most recently from f456d32 to 1a8e590 Compare December 9, 2024 23:16
@reweeden reweeden force-pushed the rew/pr-6293-cmr-storage branch 2 times, most recently from 1ed8258 to 896d6bf Compare December 10, 2024 18:26
@reweeden reweeden force-pushed the rew/pr-6293-cmr-storage branch 2 times, most recently from 0b3c379 to 8466134 Compare December 10, 2024 19:04
@reweeden reweeden force-pushed the rew/pr-6293-cmr-storage branch from 8466134 to a4c9f08 Compare December 10, 2024 19:06
@reweeden reweeden marked this pull request as ready for review December 10, 2024 19:12
@reweeden reweeden merged commit 0898c7d into main Dec 12, 2024
5 checks passed
@reweeden reweeden deleted the rew/pr-6293-cmr-storage branch December 12, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants