Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(define_attribute?): invert if logic #113

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix(define_attribute?): invert if logic #113

merged 1 commit into from
Sep 12, 2024

Conversation

mbaertschi
Copy link
Contributor

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

@zachdaniel I think the unless was wrong here. Correct me if I am wrong :-)

@zachdaniel zachdaniel merged commit a0663b2 into ash-project:main Sep 12, 2024
16 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

@mbaertschi mbaertschi deleted the fix/define_attribute branch September 12, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbaertschi @zachdaniel