From f6b01839eb66711be1a4082cd484eb7632be69fd Mon Sep 17 00:00:00 2001 From: Steffen Beyer Date: Fri, 11 Oct 2024 13:59:59 +0200 Subject: [PATCH 1/2] improvement: "full_diff tracking not atomic" error message --- lib/resource/changes/create_new_version.ex | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/resource/changes/create_new_version.ex b/lib/resource/changes/create_new_version.ex index 637ab29..29e7f75 100644 --- a/lib/resource/changes/create_new_version.ex +++ b/lib/resource/changes/create_new_version.ex @@ -22,7 +22,8 @@ defmodule AshPaperTrail.Resource.Changes.CreateNewVersion do change_tracking_mode = AshPaperTrail.Resource.Info.change_tracking_mode(changeset.resource) if change_tracking_mode == :full_diff do - {:not_atomic, "Cannot perform full_diff change tracking with AshPaperTrail atomically."} + {:not_atomic, "Cannot perform full_diff change tracking with AshPaperTrail atomically. " <> + "You might want to choose a different tracking mode or declare your actions non-atomic."} else {:ok, change(changeset, opts, context)} end From 55f9dff70ab11d5fae85257264c020b368e59b52 Mon Sep 17 00:00:00 2001 From: Zach Daniel Date: Fri, 11 Oct 2024 08:02:45 -0400 Subject: [PATCH 2/2] Update lib/resource/changes/create_new_version.ex --- lib/resource/changes/create_new_version.ex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/resource/changes/create_new_version.ex b/lib/resource/changes/create_new_version.ex index 29e7f75..1ed765a 100644 --- a/lib/resource/changes/create_new_version.ex +++ b/lib/resource/changes/create_new_version.ex @@ -23,7 +23,7 @@ defmodule AshPaperTrail.Resource.Changes.CreateNewVersion do if change_tracking_mode == :full_diff do {:not_atomic, "Cannot perform full_diff change tracking with AshPaperTrail atomically. " <> - "You might want to choose a different tracking mode or declare your actions non-atomic."} + "You might want to choose a different tracking mode or set require_atomic? to false on your update actions."} else {:ok, change(changeset, opts, context)} end