Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try support FSharp 7 #190

Closed
wants to merge 10 commits into from
Closed

Try support FSharp 7 #190

wants to merge 10 commits into from

Conversation

rstm-sf
Copy link

@rstm-sf rstm-sf commented Dec 6, 2022

No description provided.

@ashmind
Copy link
Owner

ashmind commented Jan 6, 2023

@rstm-sf This is in draft, but since the build actually passed, is F# part ready to merge?
Seems like conflicts are related to ref assembly fixes, but if it's slimmed down to F# should avoid those.

@alrz
Copy link

alrz commented Jan 11, 2023

Was just looking for this. Would love to see it get merged soon :)

ForNeVeR
ForNeVeR reviewed Feb 19, 2023
View reviewed changes
.github/workflows/dotnet.yml Outdated
dotnet-version: 6.0.x
- uses: actions/setup-dotnet@v1
with:
dotnet-version: 7.0.x

This comment was marked as outdated.

Sign in to view

@rstm-sf
Copy link
Author

rstm-sf commented Feb 19, 2023

Sorry for delay.

FCS used to depend on msbuild (https://github.com/dotnet/msbuild/tree/main/src/Utilities#netstandard20-target), but the dependency has been removed from the 43.7.200 version https://www.nuget.org/packages/FSharp.Compiler.Service/43.7.200#dependencies-body-tab

@rstm-sf rstm-sf marked this pull request as ready for review February 19, 2023 18:30
@baronfel
Copy link
Contributor

Having done these in the past, this one LGTM 👍

@rstm-sf
Merge branch 'main' into feature/support_fsharp_7
982a88f 
# Conflicts:
#	AspNetCore.Demo.Net6/packages.lock.json
#	Tests.Roslyn44/packages.lock.json
#	Tests.RoslynLatest/packages.lock.json
@rstm-sf
Copy link
Author

rstm-sf commented Jul 11, 2023

@ashmind just ping

@ijklam
Copy link

ijklam commented Dec 22, 2023

when will this be merged?

@ashmind
Copy link
Owner

ashmind commented Jun 1, 2024

Thanks for your work! Unfortunately I wasn't able to support it promptly enough due to other priorities.
However now that #223 is merged, it should cover the newest F#.

Therefore I'll close this one.

@ashmind ashmind closed this Jun 1, 2024
@rstm-sf rstm-sf deleted the feature/support_fsharp_7 branch June 1, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForNeVeR ForNeVeR ForNeVeR left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rstm-sf @ashmind @alrz @baronfel @ijklam @ForNeVeR