Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(devcontainer): add trivy and its VSCode Extension #1

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

ashnashahgrover
Copy link
Owner

Primary Changes

  1. updated trivy verion in the .devcontainer file and included AquaSecurityOfficial.trivy-vulnerability-scanner vs-code extension 2) updated trivy version in ci.yaml
  2. included AquaSecurityOfficial.trivy-vulnerability-scanner vs-code extension in the .vscode/extensions.json file 4) Updated node version so Dev container builds properly

Fixes hyperledger#2650

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Primary Changes
1) updated trivy verion in the .devcontainer file and
included AquaSecurityOfficial.trivy-vulnerability-scanner vs-code extension
2) updated trivy version in ci.yaml
3) included AquaSecurityOfficial.trivy-vulnerability-scanner
vs-code extension in the .vscode/extensions.json file
4) Updated node version so Dev container builds properly

Fixes hyperledger#2650

Signed-off-by: ashnashahgrover <as19@williams.edu>
@ashnashahgrover ashnashahgrover merged commit 40c38dc into main Jun 11, 2024
131 of 147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(devcontainer): add trivy and its VSCode Extension
1 participant