.

Signed-off-by: Simone Orru <simone.orru@secomind.com>
astarte-platform · Nov 7, 2024 · 8c12862 · 8c12862
1 parent 8797249
commit 8c12862
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 14 deletions.
diff --git a/.github/workflows/e2e-tests-grpc.yaml b/.github/workflows/e2e-tests-grpc.yaml
@@ -29,7 +29,7 @@ jobs:
     strategy:
       matrix:
         python-version: ["3.12"]
-        msghub-version: ["v0.6.1"]
+        msghub-version: ["v0.7.0"]
     concurrency:
       group: e2e-test-grpc-${{ matrix.python-version }}-${{ github.ref }}
       cancel-in-progress: true

diff --git a/astarte/device/device_grpc.py b/astarte/device/device_grpc.py
@@ -249,18 +249,16 @@ def _rx_stream_handler(self):
             try:
                 for msg_hub_event in stream:
                     astarte_message = _decode_msg_hub_event(msg_hub_event)
-                    if not astarte_message:
-                        continue
-
-                    (interface_name, path, payload) = astarte_message
-                    logging.debug(
-                        "Received message on interface: %s, endpoint %s, content: %s",
-                        str(interface_name),
-                        str(path),
-                        str(payload),
-                    )
-                    if self._on_data_received:
-                        self._on_message_generic(interface_name, path, payload)
+                    if astarte_message:
+                        (interface_name, path, payload) = astarte_message
+                        logging.debug(
+                            "Received message on interface: %s, endpoint %s, content: %s",
+                            str(interface_name),
+                            str(path),
+                            str(payload),
+                        )
+                        if self._on_data_received:
+                            self._on_message_generic(interface_name, path, payload)
             except _MultiThreadedRendezvous as exc:
                 logging.error("Status code change in the GRPC core: %s", str(exc.code()))
 
@@ -514,7 +512,7 @@ def _decode_msg_hub_event(
 
     payload = None
     if msg_hub_event.HasField("error"):
-        logging.error(f"Error from the message hub: {msg_hub_event.error.description}")
+        logging.error("Error from the message hub: %s", msg_hub_event.error.description)
     else:
         payload = _decode_astarte_message(msg_hub_event.message)