Device aliases are a map, not an array #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-mazzucato
approved these changes
Nov 12, 2024
Fix the parsing of device aliases, which are to be parsed in the same way as attributes. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@gmail.com>
Annopaolo
force-pushed
the
parse-aliases-as-maps
branch
from
714c329 to
be88292
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 51.23% 51.19% -0.04%
==========================================
Files 21 21
Lines 2637 2635 -2
==========================================
- Hits 1351 1349 -2
Misses 1180 1180
Partials 106 106 ☔ View full report in Codecov by Sentry. |
matt-mazzucato
merged commit b8a1c07
into
astarte-platform:master
11 of 13 checks passed
Annopaolo
added a commit
to Annopaolo/astartectl
that referenced
this pull request
Nov 12, 2024
Astarte Device aliases are a map. Print them as so, instead of an empty list. This follows a fix in astarte-go, see astarte-platform/astarte-go#68. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@gmail.com>
Annopaolo
added a commit
to Annopaolo/astartectl
that referenced
this pull request
Nov 12, 2024
Astarte Device aliases are a map. Print them as so, instead of an empty list. This follows a fix in astarte-go, see astarte-platform/astarte-go#68. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the parsing of device aliases, which are to be parsed in the same way as attributes.
See astarte-platform/astartectl#275.