Feature/get properties #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaato
force-pushed
the
feature/get-properties
branch
3 times, most recently
from
e001276 to
ecd9a6c
Compare
harlem88
requested changes
Dec 6, 2024
harlem88
requested changes
Dec 6, 2024
lucaato
force-pushed
the
feature/get-properties
branch
2 times, most recently
from
2a13e9e to
03a4f66
Compare
lucaato
force-pushed
the
feature/get-properties
branch
from
03a4f66 to
9d70cee
Compare
rgallor
approved these changes
Dec 6, 2024
sorru94
approved these changes
Dec 6, 2024
joshuachp
suggested changes
Dec 9, 2024
joshuachp
suggested changes
Dec 9, 2024
lucaato
force-pushed
the
feature/get-properties
branch
from
9d70cee to
88f8c9e
Compare
joshuachp
approved these changes
Dec 9, 2024
|
Since the sdk defines the major version as i32, would we like to change uint32 into int32 here? |
lucaato
force-pushed
the
feature/get-properties
branch
4 times, most recently
from
7260140 to
4323dfb
Compare
harlem88
reviewed
Dec 11, 2024
lucaato
force-pushed
the
feature/get-properties
branch
from
4323dfb to
4baf25c
Compare
Co-authored-by: Riccardo Gallo <riccardo.gallo@secomind.com> Signed-off-by: Luca Arato <luca.arato@secomind.com>
Co-authored-by: Luca Arato <luca.arato@secomind.com> Signed-off-by: Luca Arato <luca.arato@secomind.com>
lucaato
force-pushed
the
feature/get-properties
branch
from
4baf25c to
c7d3fb3
Compare
harlem88
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.