Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade codspeed-criterion-compat to 2.6.0 #11153

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

ibraheemdev
Copy link
Member

Summary

codspeed-criterion-compat 2.6.0 updates it's package selection mechanism, so #10735 is no longer needed.

Test Plan

CI should still be passing.

Copy link

codspeed-hq bot commented Apr 25, 2024

CodSpeed Performance Report

Merging #11153 will improve performances by 6.69%

Comparing ibraheemdev:codspeed-2.6 (61b9def) with main (dc09f52)

Summary

⚡ 3 improvements
✅ 27 untouched benchmarks

Benchmarks breakdown

Benchmark main ibraheemdev:codspeed-2.6 Change
linter/all-with-preview-rules[unicode/pypinyin.py] 10.1 ms 9.7 ms +4.1%
parser[numpy/ctypeslib.py] 5.6 ms 5.3 ms +6.69%
parser[pydantic/types.py] 11.9 ms 11.4 ms +4.77%

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zanieb zanieb added the ci Related to internal CI tooling label Apr 25, 2024
@charliermarsh charliermarsh merged commit 22d4f11 into astral-sh:main Apr 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to internal CI tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants