Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated E999 rule code #14428

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

MichaReiser
Copy link
Member

Summary

The E999 rule code was deprecated as part of Ruff 0.5.

This PR now removes it entirely. Using E999 is now a hard error.

Test Plan

cargo test

@MichaReiser MichaReiser added breaking Breaking API change configuration Related to settings and configuration labels Nov 18, 2024
@MichaReiser MichaReiser changed the base branch from main to ruff-0.8 November 18, 2024 10:28
@MichaReiser MichaReiser force-pushed the micha/remove-syntax-error-rule-code branch from 4710d6b to c239464 Compare November 18, 2024 10:31
Copy link
Contributor

github-actions bot commented Nov 18, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM. The ecosystem output is noisy because you changed the target branch after filing the PR, but it doesn't look like there's anything E999-related in there!

I think there's still two references to E999 elsewhere in the repo that we should get rid of:

crates/ruff/tests/integration_test.rs:    // Select any rule except for `E999`, syntax error should still be shown.
crates/ruff_workspace/src/configuration.rs:                if matches!(rule.as_str(), "E999") {

@AlexWaygood AlexWaygood added this to the v0.8 milestone Nov 18, 2024
@MichaReiser MichaReiser force-pushed the micha/remove-syntax-error-rule-code branch 2 times, most recently from c532214 to 409e516 Compare November 19, 2024 08:17
@MichaReiser MichaReiser marked this pull request as ready for review November 19, 2024 08:17
@MichaReiser MichaReiser force-pushed the micha/remove-syntax-error-rule-code branch from 409e516 to 539a6ab Compare November 19, 2024 08:45
@AlexWaygood AlexWaygood merged commit 4e1bea9 into ruff-0.8 Nov 19, 2024
16 checks passed
@AlexWaygood AlexWaygood deleted the micha/remove-syntax-error-rule-code branch November 19, 2024 12:13
@AlexWaygood AlexWaygood mentioned this pull request Nov 19, 2024
AlexWaygood pushed a commit that referenced this pull request Nov 19, 2024
MichaReiser added a commit that referenced this pull request Nov 20, 2024
MichaReiser added a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking API change configuration Related to settings and configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants