-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated E999
rule code
#14428
Conversation
4710d6b
to
c239464
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM. The ecosystem output is noisy because you changed the target branch after filing the PR, but it doesn't look like there's anything E999-related in there!
I think there's still two references to E999 elsewhere in the repo that we should get rid of:
crates/ruff/tests/integration_test.rs: // Select any rule except for `E999`, syntax error should still be shown.
crates/ruff_workspace/src/configuration.rs: if matches!(rule.as_str(), "E999") {
10c6a2a
to
5532cc0
Compare
c532214
to
409e516
Compare
409e516
to
539a6ab
Compare
Summary
The
E999
rule code was deprecated as part of Ruff 0.5.This PR now removes it entirely. Using
E999
is now a hard error.Test Plan
cargo test