Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pycodestyle] Exempt pytest.importorskip() calls (E402) #14474

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #13537.

Test Plan

cargo nextest run and cargo insta test.

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+5 -0 violations, +0 -0 fixes in 2 projects; 52 projects unchanged)

apache/airflow (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ providers/tests/weaviate/operators/test_weaviate.py:28:62: RUF100 [*] Unused `noqa` directive (unused: `E402`)

ibis-project/ibis (+4 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ ibis/backends/impala/tests/test_ddl.py:18:44: RUF100 Unused `noqa` directive (unused: `E402`)
+ ibis/backends/impala/tests/test_parquet_ddl.py:12:44: RUF100 Unused `noqa` directive (unused: `E402`)
+ ibis/backends/impala/tests/test_partition.py:15:48: RUF100 Unused `noqa` directive (unused: `E402`)
+ ibis/tests/expr/test_pretty_repr.py:13:66: RUF100 Unused `noqa` directive (unused: `E402`)

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
RUF100 5 5 0 0 0

@charliermarsh charliermarsh merged commit b9c53a7 into astral-sh:main Nov 20, 2024
20 checks passed
@charliermarsh charliermarsh added rule Implementing or modifying a lint rule preview Related to preview mode features labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't trigger E402 on pytest.importorskip above imports
2 participants