Remove lossy resolution-to-requirements conversion in install plan #7798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/plan
branch
from
f67c469
to
4343437
Compare
charliermarsh
added
the
internal
charliermarsh
commented
Sep 30, 2024
| .cloned() | ||
| .expect("Resolution should contain all packages") | ||
| }) | ||
| .collect::<Vec<_>>(); |
There was a problem hiding this comment.
Getting rid of this is so good.
charliermarsh
force-pushed
the
charlie/plan
branch
2 times, most recently
from
f7276de
to
598190a
Compare
charliermarsh
force-pushed
the
charlie/plan
branch
from
598190a
to
a7013cb
Compare
|
This will enable us to fix some very subtle bugs in future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a longstanding piece of technical debt. After we resolve, we have a bunch of
ResolvedDistentries. We then convert those toRequirement(which is lossy -- we lose information like "the index that the package was resolved to"), and then back toDist.