Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wget instructions for systems without curl #8630

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

joshmcorreia
Copy link
Contributor

Summary

Adds wget instructions for linux installations that don't come with curl.

Test Plan

This was tested on Ubuntu 20.04, Ubuntu 22.04, Ubuntu 24.04, and Debian 11.

@zanieb
Copy link
Member

zanieb commented Oct 28, 2024

We want to keep the README as small as possible here. Maybe in the documentation Installation guide instead? I'm a bit hesitant though.

@zanieb zanieb added the documentation Improvements or additions to documentation label Oct 28, 2024
@zanieb
Copy link
Member

zanieb commented Oct 28, 2024

Thanks for contributing to the project :)

@joshmcorreia
Copy link
Contributor Author

Maybe in the documentation Installation guide instead? I'm a bit hesitant though.

Is there a reason you're hesitant to add it to the installation guide?

@zanieb
Copy link
Member

zanieb commented Oct 28, 2024

It's just more content for people to read and it hasn't come up so far.

@joshmcorreia
Copy link
Contributor Author

It came up for me on a docker container without curl and I created the PR because there wasn't any existing documentation on it. Up to you on if you want to close it or not - at least if someone else faces the same problem as me they'll be able to search "wget" and find this solution.

@samypr100
Copy link
Collaborator

samypr100 commented Nov 4, 2024

@joshmcorreia Indeed, I think it's still worth adding possibly as a note in installer.md instead of the repo's README.

@zanieb zanieb enabled auto-merge (squash) November 13, 2024 17:43
@zanieb zanieb merged commit d2b9036 into astral-sh:main Nov 13, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants