Include new package name mistake suggestions #9034
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These projects are of varying popularity, so I would understand if you don't want to include all of these, lest it gets out of control. These are just some suggestions to start a conversation. From my perspective, the most important to include, I think are: - PIL - GitPython - PyYAML
| ["cv2", "opencv-python"], | ||
| ["docx", "python-docx"], | ||
| ["dotenv", "python-dotenv"], | ||
| ["fitz", "pymupdf"], |
There was a problem hiding this comment.
There was a problem hiding this comment.
This is an older thing that was changed at some point - in the past the import name fitz was the only one exposed by pymupdf, now it looks like they have moved away from that except as a fallback.
|
Thank you! As-is, I think these are only shown when a build failures, and not when a resolution fails. So we might need to change that for this to take effect. |
|
Good point. There are a variety of ways things could go wrong:
The last case should probably be the focus of this PR for now. There's also the case of two, well used and maintained packages competing over the same import name, but I don't think we could do anything about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This list of known discrepancies between package vs. import package name is missing a few very popular packages:
I have added these and a number of others I am aware of. These projects are of varying popularity, so I would understand if you don't want to include all of these, lest it gets out of control. These are just some suggestions to start a conversation.
Test Plan
No tests, since this is just adding to a JSON file. The list should be manually reviewed.