Detect nested workspace inside the current workspace and members with identical names #9094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks king! I should've clarified that I was also willing to do this if we shipped the version you have in red-knot, but I'm grateful to you for PRing it. |
|
I can do the testing etc. if you need. |
MichaReiser
commented
Nov 13, 2024
.github/workflows/ci.yml
Outdated
| @@ -23,7 +23,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| outputs: | |||
| # Flag that is raised when any code is changed | |||
| code: ${{ steps.changed.outputs.code_any_changed }} | |||
| code: ${{ steps.changed.outputs.code_any_changed }}` | |||
|
I can do it tomorrow but let me know if you have any suggestions on how/where to add automated tests for this (considering that no tests are failing, it seems there are no existing tests) |
MichaReiser
force-pushed
the
micha/workspace-discovery-nested
branch
from
a767106
to
67b88aa
Compare
charliermarsh
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Align uv's workspace discovery with red knots (see astral-sh/ruff#14308 (comment))
Test Plan
I added two integration tests. I also back ported the tests to main to verify that both these invalid workspaces aren't catched by uv today. That makes this, technically, a breaking change but I would consider the change a bug fix.