Update styles to support collapsible nav #9095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The small screen experience remains unchanged 
|
zanieb
force-pushed
the
zb/docs-collapsible
branch
2 times, most recently
from
71dab2c
to
1c65237
Compare
zanieb
force-pushed
the
zb/docs-collapsible
branch
from
1c65237
to
fcf8446
Compare
charliermarsh
approved these changes
Nov 15, 2024
| display: none; | ||
| } | ||
| @media screen and (max-width: 1219px) { | ||
| @media screen and (min-width: 76.25em) { |
There was a problem hiding this comment.
Where does this value come from?
There was a problem hiding this comment.
This value is from the main stylesheet, I figured it'd be best to match it though I think it is equivalent for most purposes?
charliermarsh
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding collapsible sections, cleans up the CSS styling we apply to the nav.
The differences here are very subtle without collapsible sections enabled. Note these screenshots show an increase in the secondary nav font size (table of contents) which I subsequently fixed.
Before
After
However, with collapsible sections you can see the bugs we're addressing
Before
After