Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequencer/mempool: CheckTX fails all rechecks #1481

Open
Lilyjjo opened this issue Sep 10, 2024 · 0 comments · May be fixed by #1515
Open

sequencer/mempool: CheckTX fails all rechecks #1481

Lilyjjo opened this issue Sep 10, 2024 · 0 comments · May be fixed by #1515
Assignees
@Lilyjjo
Labels
mempool observability observability, tracing, metrics sequencer pertaining to the astria-sequencer crate

Comments

@Lilyjjo
Copy link
Contributor

Lilyjjo commented Sep 10, 2024 •
edited by sync-by-unito bot
Loading

During the mempool rewrite CheckTX's functionality was accidentally changed to fail all CheckTxKind::Recheck calls. Previously attempting to re-insert a transaction into the mempool would not cause an error.

This is a UX regression as CometBFT is used to display to users the possible statuses of their transactions. We should allow the CheckTxKind::Recheck calls to succeed until we have better ways to report to users the status of their transactions. Nice to have also is basic unit testing for CheckTX.

┆Issue Number: ENG-811
@Lilyjjo Lilyjjo added sequencer pertaining to the astria-sequencer crate observability observability, tracing, metrics mempool labels Sep 10, 2024
@Lilyjjo Lilyjjo self-assigned this Sep 10, 2024
@Lilyjjo Lilyjjo linked a pull request Sep 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lilyjjo Lilyjjo

Labels
mempool observability observability, tracing, metrics sequencer pertaining to the astria-sequencer crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sequencer): rewrite check_tx to be more efficient and fix regression astriaorg/astria
1 participant
@Lilyjjo