Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rework transaction_priority_comparisons_should_be_consistent_nonce_diff() to avoid clippy allow #1583

Closed
ethanoroshiba opened this issue Sep 27, 2024 · 0 comments · Fixed by #1595

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Sep 27, 2024

We can rework these assertions such that they are still very human-readable and remove the clippy allow:
#1561 (comment)

// allow: we want explicit assertions here to match the documented expected behavior.
#[allow(clippy::nonminimal_bool)]
fn transaction_priority_comparisons_should_be_consistent_nonce_diff() {

┆Issue Number: ENG-875

@ethanoroshiba ethanoroshiba self-assigned this Sep 27, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 2, 2024
…ner` (#1595)

## Summary
Simplified logical statements in
`transaction_priority_comparisons_should_be_consistent_nonce_diff()`.

## Background
Previously there was an allow for `clippy::nonminimal_bool`. The
reasoning behind it was to match documented behavior. This change is
meant to explicitly state the expected behavior while still simplifying
the boolean expressions. This is in response to this comment:
#1561 (comment)

## Changes
- Simplified boolean expressions and moved the non-simplified versions
to the comments where applicable to provide context on the documented
behavior.

## Testing
Passing all tests

## Related Issues
closes #1583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant