feat(composer)!: Add chain_id check on executor build #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swapped sequencer client genesis get for sequencer client status get. Cleans up the code a bit
eoroshiba
changed the title
SuperFluffy
requested changes
Jun 13, 2024
SuperFluffy
reviewed
Jun 14, 2024
SuperFluffy
reviewed
Jun 14, 2024
joroshiba
reviewed
Jun 20, 2024
SuperFluffy
reviewed
Jul 1, 2024
There was a problem hiding this comment.
Code is moving in the right direction, thank you for bearing with me and working on it. :)
I have left a bunch of comments on what what I'd like to see changed to test this.
The tests are currently not set up in the most ideal way, but short of making the exit reason publicly observable I don't see a way for you to test it other than you did.
I would only ask for you to type out the returned errors so that the tests won't stop silently breaking (and yet still passing).
Co-authored-by: Richard Janis Goldschmidt <github@aberrat.io>
|
@SuperFluffy I should be thanking you for bearing with me! Recent commits should implement all the changes you requested. |
SuperFluffy
approved these changes
Jul 2, 2024
SuperFluffy
reviewed
Jul 3, 2024
| assert_eq!(*actual, *configured_actual); | ||
| } | ||
| other @ EnsureChainIdError::GetChainId(_) => { | ||
| panic!("expected `EnsureChainIdError::WrongChainId`, but got '{other}'") |
There was a problem hiding this comment.
Last change before merge:
Suggested change
| panic!("expected `EnsureChainIdError::WrongChainId`, but got '{other}'") | |
| panic!("expected `EnsureChainIdError::WrongChainId`, but got '{other:?}'") |
^ I'd have done it myself but don't have push rights for your fork.
Co-authored-by: Richard Janis Goldschmidt <github@aberrat.io>
bharath-123
pushed a commit
that referenced
this pull request
Jul 25, 2024
## Summary Added check to ensure the executor's configured chain_id and the sequencer client's actual chain_id match. ## Background This check ensures that the composer is communicating with the sequencer RPC on the correct network. ## Changes Added chain_id check to the composer executor builder. Made executor builder async to accommodate for async communication with sequencer client. Moved nonce guard declaration from mock startup to individual tests in executor tests. Added function to mount a status response with a given chain_id to the mock. This is so the executor builder can gather the status response without throwing an HTTP 404 error. ## Testing Added executor test to validate the failure of an executor build with a chain_id mismatch. ## Related Issues Part of #986 --------- Co-authored-by: Richard Janis Goldschmidt <github@aberrat.io> Co-authored-by: Ethan Oroshiba <ethan@astria.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added check to ensure the executor's configured chain_id and the sequencer client's actual chain_id match.
Background
This check ensures that the composer is communicating with the sequencer RPC on the correct network.
Changes
Added chain_id check to the composer executor builder.
Made executor builder async to accommodate for async communication with sequencer client.
Moved nonce guard declaration from mock startup to individual tests in executor tests.
Added function to mount a status response with a given chain_id to the mock. This is so the executor builder can gather the status response without throwing an HTTP 404 error.
Testing
Added executor test to validate the failure of an executor build with a chain_id mismatch.
Related Issues
Part of #986