feat(conductor)!: add sequencer chain_id validation #1197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noot
reviewed
Jun 24, 2024
noot
reviewed
Jun 24, 2024
| sequencer::CancellationToken, | ||
| }; | ||
|
|
||
| async fn mount_genesis(mock_http: &MockServer, sequencer_chain_id: &str) { |
There was a problem hiding this comment.
can you use the existing helpers::mount_genesis function instead of this? since this is only used in the chain-id mismatch test, you can just set the sequencer_chain_id in the builder to a different value than the default set in helpers::mount_genesis.
There was a problem hiding this comment.
I might be mistaken, but I believe helpers::mount_genesis is only available to tests/blackbox. I created the test file within src/sequencer so that the functionality of the chain ID check could be tested without doing all the other necessary mounts/calls for the full conductor. Would you prefer to move this to the tests/blackbox folder and perform the mounts so that it can utilize helpers::mount_genesis?
Co-authored-by: noot <36753753+noot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added configured sequencer chain_id check against remote.
Background
This is to prevent the conductor from connecting to the wrong sequencer network.
Changes
Added sequencer chain ID configuration option for specifying expected sequencer chain ID.
Added check to ensure configured and remote chain IDs match within sequencer reader run_until_stopped() function.
Added function to retrieve the remote sequencer chain ID and check against configured chain ID. This function retrieves the remote chain ID from the sequencer network genesis file.
Testing
Added new sequencer test file to allow access to sequencer without needing to mount anything other than the genesis file. This includes a test to ensure failure on mismatched chain IDs.
Breaking Changelist
Related Issues
Part of #986