Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conductor)!: add sequencer and celestia chain ID verification #1264

Closed
wants to merge 3 commits into from

Conversation

eoroshiba
Copy link
Contributor

@eoroshiba eoroshiba commented Jul 12, 2024

Summary

Added verification checks for sequencer and Celestia chain IDs against remote within conductor.

Background

Previously, the conductor may have connected to the incorrect sequence or Celestia network. These changes are to ensure that the conductor is communicating with the expected network.

Changes

  • Added sequencer and Celestia chain ID environment variables.
  • Implemented traits for sequencer and Celestia clients to get remote chain IDs.
  • Added chain ID check function, which is called within initialization in conductor run_until_stopped().
  • Adjusted conductor run_until_stopped() to be able to return an error, allowing a failure in chain_id verification to be propagated.
  • Added respective tests for failure in blackbox tests.

Testing

Added 4 blackbox tests, with firm commitment levels testing for failure with Celestia chain ID mismatch, and soft commitment levels testing for failure with sequencer chain ID mismatch.

Breaking Changelist

  • Added ASTRIA_CONDUCTOR_SEQUENCER_CHAIN_ID
  • Added ASTRIA_CONDUCTOR_CELESTIA_CHAIN_ID

Related Issues

Part of #986

@github-actions github-actions bot added the conductor pertaining to the astria-conductor crate label Jul 12, 2024
@eoroshiba eoroshiba marked this pull request as ready for review July 12, 2024 18:46
@eoroshiba eoroshiba requested review from a team as code owners July 12, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conductor pertaining to the astria-conductor crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants