feat(conductor)!: add sequencer and celestia chain ID verification #1264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added verification checks for sequencer and Celestia chain IDs against remote within conductor.
Background
Previously, the conductor may have connected to the incorrect sequence or Celestia network. These changes are to ensure that the conductor is communicating with the expected network.
Changes
run_until_stopped()
.run_until_stopped()
to be able to return an error, allowing a failure in chain_id verification to be propagated.Testing
Added 4 blackbox tests, with firm commitment levels testing for failure with Celestia chain ID mismatch, and soft commitment levels testing for failure with sequencer chain ID mismatch.
Breaking Changelist
ASTRIA_CONDUCTOR_SEQUENCER_CHAIN_ID
ASTRIA_CONDUCTOR_CELESTIA_CHAIN_ID
Related Issues
Part of #986