Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auctioneer): add auctioneer binary boilerplate #1556

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

itamarreif
Copy link
Contributor

@itamarreif itamarreif commented Sep 24, 2024

Summary

This PR adds the Auctioneer crate and boilerplate for a new binary.

Background

The new binary will be used for the auctioneer service. See the Auctioneer master issue for more context.

Changes

  • Add auctioneer crate to workspace's Cargo.toml file
  • Metrics, build info, config and boilerplate for setting up the binary
    • The metrics object is currently empty but I kept it in because it will be used in followup prs
  • Publicly exposed auctioneer::Auctioneer handle for managing spawn and shutdown due to SIGTERM
  • Internal service implementation in auctioneer::Inner sets up the main object responsible for intiialization, running, and graceful shutdown
  • Boilerplate for a single subtask that will be implemented a subsequent pr.

Testing

  • Should I add any black box test boilerplate with this?

Breaking Changelist

  • Bulleted list of breaking changes, any notes on migration. Delete section if none.

Related Issues

closes #1534, #1535, #1538,

@github-actions github-actions bot added the proto pertaining to the Astria Protobuf spec label Sep 24, 2024
@itamarreif itamarreif changed the base branch from main to itamarreif/auctioneer/initial-protos September 24, 2024 22:50
@itamarreif itamarreif self-assigned this Sep 24, 2024
@itamarreif itamarreif changed the title feat(auctioneer): add auctioneer package and binary boilerplate feat(auctioneer): add auctioneer binary boilerplate Sep 24, 2024
@itamarreif itamarreif changed the base branch from itamarreif/auctioneer/initial-protos to main September 24, 2024 22:58
@itamarreif itamarreif marked this pull request as ready for review September 24, 2024 23:18
@itamarreif itamarreif requested review from a team as code owners September 24, 2024 23:18
@itamarreif itamarreif requested review from noot, quasystaty1 and SuperFluffy and removed request for noot September 24, 2024 23:18
@SuperFluffy SuperFluffy marked this pull request as draft September 25, 2024 14:18
@itamarreif itamarreif changed the base branch from main to itamarreif/auctioneer/initial-protos September 25, 2024 20:03
@github-actions github-actions bot added ci issues that are related to ci and github workflows conductor pertaining to the astria-conductor crate sequencer pertaining to the astria-sequencer crate docker cd labels Sep 25, 2024
@bharath-123 bharath-123 force-pushed the itamarreif/auctioneer/initial-protos branch from 009764a to 30b0a5a Compare September 26, 2024 14:54
@itamarreif itamarreif force-pushed the itamarreif/auctioneer/initial-protos branch from 30b0a5a to b91925a Compare September 26, 2024 15:50
@itamarreif itamarreif force-pushed the itamarreif/auctioneer/eng-824 branch 2 times, most recently from eeac942 to 8e0f93a Compare September 26, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auctioneer cd ci issues that are related to ci and github workflows conductor pertaining to the astria-conductor crate docker proto pertaining to the Astria Protobuf spec sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Fork" the composer to add an auctioneer crate
1 participant