Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): hermes monitoring and prometheus rules #1564

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

quasystaty1
Copy link
Contributor

@quasystaty1 quasystaty1 commented Sep 25, 2024

Summary

Fixes hermes related monitoring service with Prometheus scraping and adds prometheus rules template for alerts.

Background

hermes monitoring service is misconfigured and alerts are yet to be implemented.

Changes

adds serviceMonitor and prometheusRule templates enabling data scraping and alerts with prometheus.
also fixes current service porting and default image and labels.

Testing

against dusk-10, locally

Metrics

enables hermes-relayer metrics scraping

@github-actions github-actions bot added the cd label Sep 25, 2024
@quasystaty1 quasystaty1 force-pushed the quasystaty1/charts/hermes-service-monitor branch from 8d0a96c to b35df28 Compare September 25, 2024 22:45
@quasystaty1 quasystaty1 force-pushed the quasystaty1/charts/hermes-service-monitor branch from b35df28 to 4a01516 Compare September 30, 2024 13:56
@quasystaty1 quasystaty1 marked this pull request as ready for review September 30, 2024 13:59
@quasystaty1 quasystaty1 requested a review from a team as a code owner September 30, 2024 13:59
@@ -8,7 +8,7 @@ enabled = {{ .Values.rest.enabled }}

# Specify the IPv4/6 host over which the built-in HTTP server will serve the RESTful
# API requests. Default: 127.0.0.1
host = '127.0.0.1'
host = '0.0.0.0'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows docker to expose metrics and api

@@ -3,7 +3,7 @@ global:
replicaCount: 1
logLevel: debug

image: ghcr.io/penumbra-zone/hermes:main
image: ghcr.io/astriaorg/hermes:sha-450f848
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uses the updated hermes version which should be tagged

@quasystaty1 quasystaty1 added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 8e10279 Oct 3, 2024
46 checks passed
@quasystaty1 quasystaty1 deleted the quasystaty1/charts/hermes-service-monitor branch October 3, 2024 22:29
steezeburger added a commit that referenced this pull request Oct 7, 2024
* main:
  refactor(sequencer): generate `SequencerBlock` after transaction execution in proposal phase (#1562)
  fix(sequencer)!: rewrite check_tx to be more efficient and fix regression (#1515)
  fix(charts): hermes monitoring and prometheus rules  (#1564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants