-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(charts): hermes monitoring and prometheus rules #1564
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasystaty1
force-pushed
the
quasystaty1/charts/hermes-service-monitor
branch
from
September 25, 2024 22:45
8d0a96c
to
b35df28
Compare
quasystaty1
force-pushed
the
quasystaty1/charts/hermes-service-monitor
branch
from
September 30, 2024 13:56
b35df28
to
4a01516
Compare
quasystaty1
commented
Sep 30, 2024
@@ -8,7 +8,7 @@ enabled = {{ .Values.rest.enabled }} | |||
|
|||
# Specify the IPv4/6 host over which the built-in HTTP server will serve the RESTful | |||
# API requests. Default: 127.0.0.1 | |||
host = '127.0.0.1' | |||
host = '0.0.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allows docker to expose metrics and api
quasystaty1
commented
Sep 30, 2024
@@ -3,7 +3,7 @@ global: | |||
replicaCount: 1 | |||
logLevel: debug | |||
|
|||
image: ghcr.io/penumbra-zone/hermes:main | |||
image: ghcr.io/astriaorg/hermes:sha-450f848 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses the updated hermes version which should be tagged
WafflesVonMaple
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes hermes related monitoring service with Prometheus scraping and adds prometheus rules template for alerts.
Background
hermes monitoring service is misconfigured and alerts are yet to be implemented.
Changes
adds
serviceMonitor
andprometheusRule
templates enabling data scraping and alerts with prometheus.also fixes current service porting and default image and labels.
Testing
against dusk-10, locally
Metrics
enables
hermes-relayer
metrics scraping