Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: code freeze through github actions #1588

Merged
merged 12 commits into from
Oct 1, 2024
Merged

Conversation

joroshiba
Copy link
Member

@joroshiba joroshiba commented Sep 27, 2024

Summary

Adds functionality to block PRs into sections of code under code freeze within the CI workflow

Background

We are moving towards mainnet & undergoing audits. During past audits we have not had a firm mechanism to ensure we are not making changes to code under audit. This provides a stopper, but can be overriden still.

Changes

  • New CI workflow that checks for changes to code frozen pathways, fails and adds errors to those files as well as building an error summary. Using the override-freeze tag disables the check and changes reports to warnings.

Testing

Ran against this PR with multiple changes, tested both adding and removing the label to override.

@joroshiba joroshiba requested a review from a team as a code owner September 27, 2024 18:12
@github-actions github-actions bot added the ci issues that are related to ci and github workflows label Sep 27, 2024
@joroshiba joroshiba requested a review from a team as a code owner September 27, 2024 18:14
@github-actions github-actions bot added the sequencer-relayer pertaining to the astria-sequencer-relayer crate label Sep 27, 2024
@joroshiba joroshiba marked this pull request as draft September 27, 2024 18:14
@joroshiba joroshiba marked this pull request as ready for review September 27, 2024 19:30
Copy link
Contributor

@WafflesVonMaple WafflesVonMaple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice idea

@joroshiba joroshiba added this pull request to the merge queue Oct 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2024
@joroshiba joroshiba added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 89d94c0 Oct 1, 2024
43 checks passed
@joroshiba joroshiba deleted the joroshiba/code-freeze-support branch October 1, 2024 15:45
steezeburger added a commit that referenced this pull request Oct 7, 2024
* main: (34 commits)
  feat(proto): add bundle and optimistic block apis (#1519)
  feat(sequencer)!: make empty transactions invalid  (#1609)
  chore(sequencer): simplify boolean expressions in `transaction container` (#1595)
  refactor(cli): merge argument parsing and command execution (#1568)
  feat(charts): astrotrek chart (#1513)
  chore(charts): genesis template to support latest changes (#1594)
  fix(ci): code freeze action fix (#1610)
  chore(sequencer)!: exclusively use Borsh encoding for stored data (ENG-768) (#1492)
  ci: code freeze through github actions (#1588)
  refactor(sequencer): use builder pattern for transaction container tests (#1592)
  feat(conductor)!: implement chain ID checks (#1482)
  chore(ci): upgrade audit-check (#1577)
  feat(sequencer)!: transaction categories on UnsignedTransaction (#1512)
  fix(charts): sequencer prometheus rules   (#1598)
  chore(all): Migrate all instances of `#[allow]` to `#[expect]` (#1561)
  chore(charts,sequencer-faucet): asset precision (#1517)
  chore(docs): endpoints (#1543)
  fix(docker): use target binary build param as name of image entrypoint (#1573)
  fix(ci): ibc bridge test timeout (#1587)
  Feature: Add `graph-node` to charts. (#1489)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues that are related to ci and github workflows sequencer-relayer pertaining to the astria-sequencer-relayer crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants