Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charts): rollup application monitoring #1601

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fix(charts): rollup application monitoring #1601

merged 2 commits into from
Oct 14, 2024

Conversation

quasystaty1
Copy link
Contributor

Summary

Fixes prometheus rules and metrics templates for geth, conductor, bridge-withdrawer and composer charts

Background

ServiceMonitors for alerting and monitoring is missing on charts

Changes

  • adds service monitor and prometheus rules templating for composer, conductor and bridge-withdrawer
  • fix service labels and selectors for all charts
  • adds default labels

Testing

against dusk-10

Metrics

  • enables metrics and alerts on rollup apllications

Related Issues

closes #1600

@quasystaty1 quasystaty1 requested a review from a team as a code owner September 30, 2024 16:56
@github-actions github-actions bot added the cd label Sep 30, 2024
@quasystaty1 quasystaty1 force-pushed the quasystaty1/charts/rollup-prometheus branch 2 times, most recently from b708b35 to 2d2e93e Compare October 3, 2024 21:19
@quasystaty1 quasystaty1 force-pushed the quasystaty1/charts/rollup-prometheus branch from 2d2e93e to 49b107c Compare October 14, 2024 13:12
@quasystaty1 quasystaty1 added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 80b8cf9 Oct 14, 2024
44 checks passed
@quasystaty1 quasystaty1 deleted the quasystaty1/charts/rollup-prometheus branch October 14, 2024 13:32
steezeburger added a commit that referenced this pull request Oct 16, 2024
@steezeburger
Merge branch 'main' into spike/noble-usdc
0f623a4 
* main:
  feat(sequencer)!: rework all fees (#1647)
  fix(sequencer): fix app hash in horcrux sentries (#1646)
  fix(composer)!: update to work with appside mempool (#1643)
  fix(charts): rollup application monitoring (#1601)
@quasystaty1 quasystaty1 mentioned this pull request Oct 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
@quasystaty1
fix(charts): composer PrometheusRule (#1733)
d5f7a19 
## Summary
adds prometheusrule object to composer chart
## Background
Prometheus rule object file was overlooked in prior #1601 
## Changes
- add prometheusRule object to enable alerts on monitoring stack
- also fixes issue with composer metric port violating targetPort length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WafflesVonMaple WafflesVonMaple WafflesVonMaple approved these changes

@steezeburger steezeburger Awaiting requested review from steezeburger steezeburger is a code owner automatically assigned from astriaorg/infra

Assignees
No one assigned
Labels
cd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(charts): rollup applications alerts
2 participants
@quasystaty1 @WafflesVonMaple