Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add ibc sudo address change command #1749

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

quasystaty1
Copy link
Contributor

Summary

adds ibc sudo address change command

Background

Cli currently does not support the IbcSudoChange action

Changes

  • added IbcSudoChange command to the cli as sudo command

Testing

tested manually against dusk-11 network

Related Issues

part of #1474

@quasystaty1 quasystaty1 requested a review from a team as a code owner October 25, 2024 16:56
@quasystaty1 quasystaty1 force-pushed the quasystaty1/cli/sudo-ibc-change branch from 27f64f7 to 1f39d2a Compare October 25, 2024 16:59
}),
)
.await
.wrap_err("failed to submit SudoAddressChange transaction")?;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.wrap_err("failed to submit SudoAddressChange transaction")?;
.wrap_err("failed to submit IbcSudoChange transaction")?;

.await
.wrap_err("failed to submit SudoAddressChange transaction")?;

println!("SudoAddressChange completed!");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
println!("SudoAddressChange completed!");
println!("IbcSudoChange completed!");

@quasystaty1 quasystaty1 force-pushed the quasystaty1/cli/sudo-ibc-change branch from ce42574 to 6122c1d Compare November 6, 2024 12:19
@quasystaty1 quasystaty1 added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 1ac8458 Nov 6, 2024
46 checks passed
@quasystaty1 quasystaty1 deleted the quasystaty1/cli/sudo-ibc-change branch November 6, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants