chore(conductor): clean up chain id tests #1765
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Shortened conductor chain ID tests.
Background
The chain ID tests necessitate awaiting the conductor's shutdown and checking its result, which is made difficult by the fact that
TestConductorimplements theDroptrait. This cleans up the tests by making use ofManuallyDrop, at the expense of using the unsafeptr::readfunction to await the conductor handle. Becausedropis never called, though, this reference is not read again.Changes
ManuallyDrop<TestConductor>to avoid having to manually set up the conductor for chain ID tests.Testing
Tests working correctly.
Changelogs
No updates required.
Related Issues
closes #1602