chore(core, sequencer): move stateless checks to domain type parsing #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanoroshiba
commented
Oct 30, 2024
| if timeout_time == 0 { | ||
| return Err(Ics20WithdrawalError::invalid_timeout_time()); | ||
| } | ||
| if amount == 0 { |
There was a problem hiding this comment.
Do we even need to check this? Protobuf represents 0 values as empty, and when decoding this it should result in None I think
ethanoroshiba
commented
Oct 30, 2024
Comment on lines
+1061
to
+1062
| let parsed_withdrawal: Ics20WithdrawalFromRollup = | ||
| serde_json::from_str(&memo).map_err(Ics20WithdrawalError::parse_memo)?; |
There was a problem hiding this comment.
Should we edit our domain type Ics20Withdrawal to then include the parsed withdrawal as well? Then, we don't have to parse again during check_and_execute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved stateless checks for
Ics20WithdrawalandBridgeUnlockto occur when the types are parsed from protobuf.Background
Made more sense to check these fields sooner in the process rather than later, and be able to consolidate some of the checks that are shared between
BridgeUnlockandIcs20Withdrawal.Changes
Ics20WithdrawalandBridgeUnlockto profobuftry_from_rawandtry_from_raw_refimpls.Testing
Passing all tests.
Changelogs
No updates required.
Related Issues
closes #1430