fix(bridge-withdrawer): also set metric when value 0 #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraser999
approved these changes
Oct 30, 2024
bharath-123
pushed a commit
that referenced
this pull request
Nov 5, 2024
## Summary The metric `batch_total_settled_value` was not being set to zero when blocks where empty, resulting in maintaining previous value and resetting incorrectly when no txs processed. ## Changes - Updated metric to be set to 0 when block is empty ## Changelogs Changelogs updated. ## Metrics - `batch_total_settled_value` improved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The metric
batch_total_settled_valuewas not being set to zero when blocks where empty, resulting in maintaining previous value and resetting incorrectly when no txs processed.Changes
Changelogs
Changelogs updated.
Metrics
batch_total_settled_valueimproved