Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to intro sections and just commands for cluster deploys #6

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Updates to intro sections and just commands for cluster deploys #6

merged 7 commits into from
Oct 18, 2023

Conversation

sambukowski
Copy link
Contributor

No description provided.

joroshiba
joroshiba reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@joroshiba joroshiba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a change we wanted to make? Thought Josh had said it seemed wrong? (note not seeing the link here, so recommented)

@sambukowski
Copy link
Contributor Author

Looking back at the conversation, Josh said that he approved it?
It's also a first step towards what Josh wanted for the just deploy-ingress-controller [ kind | gke | azure | do | aws ] command.

@sambukowski sambukowski merged commit 59cbbe5 into main Oct 18, 2023
1 check passed
@sambukowski sambukowski deleted the sb/intro-updates branch October 18, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbowen93 jbowen93 jbowen93 approved these changes

@joroshiba joroshiba Awaiting requested review from joroshiba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sambukowski @joroshiba @jbowen93