Get rid of effect group part in paging tokens

[charlie-wasp]

Here's an attempt to get rid of EffectGroup component in our paging tokens (ids, in fact). It would help us to save some space on the disk

The idea is simple: trades indices start from the last balance effect index, so their ids won't overlap

Also, we had a little bug, which caused balances ids to have gaps. I fixed that in this PR too

---

This change is 

[gzigzigzeo]

That shall work, but I have the concern: from what I understood, non-operation effects will have fake operation number in their IDs. That operation number would be last op index + 1. So, it would be impossible to figure out related operation without context, given you have effect ID value only. Would it not be better to have some reserved operation number for trade effects instead of last op index? Like, 9999 or 0? @charlie-wasp

[nebolsin]

@gzigzigzeo tx-level effects (fees) will have operation Id 0, all other effects, including trades, are related to some operation, so there shouldn’t be any fake ids

[charlie-wasp]

@gzigzigzeo I am not sure that I fully understand your concern. I didn't introduce any fake operation numbers. I just made trade effects indices to start from the last balance effect index 🙂

[nebolsin]

@charlie-wasp LGTM, but please check that we correctly handling tx-level signer updates (happens automatically when pre-authorized tx is executed)

[charlie-wasp]

@nebolsin that's interesting, on the tx-level only fee effects serialization is performed, no signers involved at all. I guess we have yet to implement this

UPDATE: here is exact code, which handles tx-level

https://github.com/astroband/astrologer/pull/17/files#diff-e58643b20d67a994fb21ad6ee79ee58fR41-R43

[charlie-wasp]

Well, I opened the issue about pre-authorized transactions — #18. I implement it in a separate PR, and now I'm merging this 🚢