Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved moon_altaz to the non-location get_moon #223

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kvyh
Copy link
Contributor

@kvyh kvyh commented Aug 5, 2016

This is a follow-up to #213 and removes the location kwarg from the get_moon call inside Observer.moon_altaz and uses the array for the following .alt, .az, and .distances.

@bmorris3
Copy link
Contributor

bmorris3 commented Aug 5, 2016

I left this out of #213 on purpose, because the moon alt/az will be more affected by an observer's location on the Earth than the moon phase. So I intended to leave this method as it is until astropy/astropy#5216 is merged, and then we can fix this method. Sorry I didn't explain that in #213.

@kvyh
Copy link
Contributor Author

kvyh commented Aug 5, 2016

The transformation to alt/az coordinates still uses the location. If this isn't changed, the MoonIlluminationConstraint needs to be rewritten, since it ends up calling Observer.moon_altaz which is currently still really slow for array times.

@kvyh kvyh mentioned this pull request Aug 11, 2016
@StuartLittlefair
Copy link
Contributor

As I understand it, there's no issue with the general idea here. It doesn't matter what frame you transform from, the alt-az coordinate of the moon will be the same as long as the original coordinate points at the moon.

So using get_moon with no location and transforming to the correct alt_az frame makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants