Added near meridian constraint #589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonefoster
force-pushed
the
add-near-meridian-contraint
branch
from
da62738
to
db11881
Compare
bmorris3
reviewed
Aug 12, 2024
There was a problem hiding this comment.
Thanks @ramonefoster, this is great!
My only real comment is about the name. When you first read it, it may be a bit ambiguous if this constraint includes or excludes targets are near the meridian.
Could we rename it MeridianSeparationConstraint, and add a max keyword argument? This would make it clear that the constraint sets angular limits relative to the meridian.
|
Hello, @bmorris3 . Thanks for the suggestion, it was indeed a needed change. I have it fixed. |
Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
…nefoster/astroplan into add-near-meridian-contraint
…near-meridian-contraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created NearMeridianContraint, that can be useful for observations using German-Equatorial Mounts, to avoid flipping the side of pier during exposures.