Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nonfunctional grid keyword in finder plot #591

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove nonfunctional grid keyword in finder plot #591

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a5929a
remove nonfunctional grid keyword
keflavich Aug 25, 2024
9ce8444
grid keyword still needed, just not passed to skyview
keflavich Aug 25, 2024
c530136
pass kwargs to skyview
keflavich Aug 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions astroplan/plots/finder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
@u.quantity_input(fov_radius=u.deg)
def plot_finder_image(target, survey='DSS', fov_radius=10*u.arcmin,
log=False, ax=None, grid=False, reticle=False,
style_kwargs=None, reticle_style_kwargs=None):
style_kwargs=None, reticle_style_kwargs=None,
skyview_kwargs={}
):
"""
Plot survey image centered on ``target``.

Expand Down Expand Up @@ -62,6 +64,11 @@ def plot_finder_image(target, survey='DSS', fov_radius=10*u.arcmin,
A dictionary of keywords passed into `~matplotlib.pyplot.axvline` and
`~matplotlib.pyplot.axhline` to set reticle style.

skyview_kwargs : dict or `None`, optional.
A dictionary of keywords passed into
`~astroquery.skyview.SkyView.get_images` to set parameters of the
retrieved image.

Returns
-------
ax : `~matplotlib.axes.Axes`
Expand All @@ -86,7 +93,8 @@ def plot_finder_image(target, survey='DSS', fov_radius=10*u.arcmin,
target_name = None if isinstance(target, SkyCoord) else target.name

hdu = SkyView.get_images(position=position, coordinates=coordinates,
survey=survey, radius=fov_radius, grid=grid)[0][0]
survey=survey, radius=fov_radius,
**skyview_kwargs)[0][0]
wcs = WCS(hdu.header)

# Set up axes & plot styles if needed.
Expand Down
Loading