Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some warnings in test #594

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

vandalt
Copy link

@vandalt vandalt commented Sep 20, 2024

This fixes two warnings I saw when running tests:

  1. Deprecation warning for ax.plot_date: fixed by using ax.plot with datetime64 instead
  2. Warnings about non-rotation transforms when calculating Sun and Moon separations. Fixed by adding origin_mismach="ignore" to those two calculations. There is already a comment about this before both instances and removing the warning avoids end users seeing it and wondering if something is wrong with how they specified coordinates.

This removes the warnings about non-rotation transform.
There is a comment before both instances to warn future editors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant